GH-73991: Add pathlib.Path.copy() - #119058
Merged
barneygale merged 19 commits intoJun 14, 2024
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Add a `Path.copy()` method that copies a file to a target file or directory using `shutil.copy2()`. In the private pathlib ABCs, we add a version that supports copying from one instance of `PathBase` to another. We don't copy metadata, because doing so probably requires new APIs that haven't been designed yet.
Copy link
Copy Markdown
Contributor
Author
|
Marking this PR as a draft, because I think we'll need to introduce os.copy() first. |
Sorry, something went wrong.
barneygale
marked this pull request as draft
May 27, 2024 14:40
barneygale
marked this pull request as ready for review
June 3, 2024 06:42
zooba
reviewed
Jun 4, 2024
zooba
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Just some thoughts, nothing I'd necessarily block the PR on. I like the way it looks overall!
Sorry, something went wrong.
Comment thread
Doc/library/pathlib.rst
Outdated
Comment thread
Lib/pathlib/_local.py
Outdated
Comment thread
Lib/pathlib/_abc.py
Outdated
eryksun
reviewed
Jun 5, 2024
Comment thread
Lib/pathlib/_local.py
Outdated
eryksun
reviewed
Jun 6, 2024
Comment thread
Lib/pathlib/_os.py
Outdated
eryksun
reviewed
Jun 6, 2024
Comment thread
Lib/pathlib/_os.py
Outdated
eryksun
reviewed
Jun 6, 2024
Comment thread
Lib/pathlib/_os.py
Outdated
zooba
reviewed
Jun 6, 2024
Comment thread
Modules/_winapi.c
Outdated
Co-authored-by: Eryk Sun <eryksun@gmail.com>
Copy link
Copy Markdown
Member
|
Looks fine to me, but I only quickly reskimmed it. I'll be away for the next few days, so don't wait for me if you guys think it's ready. |
Sorry, something went wrong.
mrahtz
pushed a commit
to mrahtz/cpython
that referenced
this pull request
Jun 30, 2024
Add a `Path.copy()` method that copies the content of one file to another. This method is similar to `shutil.copyfile()` but differs in the following ways: - Uses `fcntl.FICLONE` where available (see pythonGH-81338) - Uses `os.copy_file_range` where available (see pythonGH-81340) - Uses `_winapi.CopyFile2` where available, even though this copies more metadata than the other implementations. This makes `WindowsPath.copy()` more similar to `shutil.copy2()`. The method is presently _less_ specified than the `shutil` functions to allow OS-specific optimizations that might copy more or less metadata. Incorporates code from pythonGH-81338 and pythonGH-93152. Co-authored-by: Eryk Sun <eryksun@gmail.com>
noahbkim
pushed a commit
to hudson-trading/cpython
that referenced
this pull request
Jul 11, 2024
Add a `Path.copy()` method that copies the content of one file to another. This method is similar to `shutil.copyfile()` but differs in the following ways: - Uses `fcntl.FICLONE` where available (see pythonGH-81338) - Uses `os.copy_file_range` where available (see pythonGH-81340) - Uses `_winapi.CopyFile2` where available, even though this copies more metadata than the other implementations. This makes `WindowsPath.copy()` more similar to `shutil.copy2()`. The method is presently _less_ specified than the `shutil` functions to allow OS-specific optimizations that might copy more or less metadata. Incorporates code from pythonGH-81338 and pythonGH-93152. Co-authored-by: Eryk Sun <eryksun@gmail.com>
estyxx
pushed a commit
to estyxx/cpython
that referenced
this pull request
Jul 17, 2024
Add a `Path.copy()` method that copies the content of one file to another. This method is similar to `shutil.copyfile()` but differs in the following ways: - Uses `fcntl.FICLONE` where available (see pythonGH-81338) - Uses `os.copy_file_range` where available (see pythonGH-81340) - Uses `_winapi.CopyFile2` where available, even though this copies more metadata than the other implementations. This makes `WindowsPath.copy()` more similar to `shutil.copy2()`. The method is presently _less_ specified than the `shutil` functions to allow OS-specific optimizations that might copy more or less metadata. Incorporates code from pythonGH-81338 and pythonGH-93152. Co-authored-by: Eryk Sun <eryksun@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a Path.copy() method that copies the content of one file to another.
This method is similar to shutil.copyfile() but differs in the following ways:
The method is deliberately less specified than the shutil functions to allow OS-specific optimizations that might copy more or less metadata.
Incorporates code by @illia-v and @giampaolo from #81338 and #93152 respectively.
📚 Documentation preview 📚: https://cpython-previews--119058.org.readthedocs.build/