GH-73991: Add pathlib.Path.rmtree() - #119060
Merged
barneygale merged 23 commits intoJul 20, 2024
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Add a `Path.rmtree()` method that removes an entire directory tree using `shutil.rmtree()`. The signature of the optional *on_error* argument matches the `Path.walk()` argument of the same name, but differs from the *onexc* and *onerror* arguments to `shutil.rmtree()`. Consistency within pathlib is probably more important. In the private pathlib ABCs, we add an implementation based on `walk()`.
barneygale
marked this pull request as draft
June 14, 2024 20:09
barneygale
marked this pull request as ready for review
June 19, 2024 00:42
picnixz
reviewed
Jul 3, 2024
picnixz
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Thank you for that addition by the way. Here are some nitpicking comments.
Sorry, something went wrong.
Comment thread
Doc/library/pathlib.rst
Outdated
Comment thread
Doc/library/pathlib.rst
Outdated
Comment thread
Doc/library/pathlib.rst
Outdated
Comment thread
Doc/library/pathlib.rst
Outdated
Comment thread
Doc/library/pathlib.rst
Outdated
Comment thread
Doc/whatsnew/3.14.rst
Outdated
Comment thread
Doc/library/pathlib.rst
Outdated
Comment thread
Lib/pathlib/_abc.py
Comment thread
Lib/pathlib/_abc.py
Outdated
Comment thread
Lib/pathlib/_abc.py
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
barneygale
enabled auto-merge (squash)
July 20, 2024 17:48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a Path.rmtree() method that removes an entire directory tree, like shutil.rmtree(). The signature of the optional on_error argument matches the Path.walk() argument of the same name, but differs from the onexc and onerror arguments to shutil.rmtree(). Consistency within pathlib is probably more important.
In the private pathlib ABCs, we add an implementation based on walk().
📚 Documentation preview 📚: https://cpython-previews--119060.org.readthedocs.build/