gh-119064: Use os_helper.FakePath instead of pathlib.Path in tests - #119065
Merged
serhiy-storchaka merged 2 commits intoMay 16, 2024
Merged
gh-119064: Use os_helper.FakePath instead of pathlib.Path in tests#119065serhiy-storchaka merged 2 commits into
serhiy-storchaka merged 2 commits into
Conversation
serhiy-storchaka
requested review from
a team,
1st1,
asvetlov,
ericsnowcurrently,
ethanfurman,
gpshead,
gvanrossum,
jaraco,
kumaraditya303,
vsajip and
willingc
as code owners
May 15, 2024 08:54
serhiy-storchaka
force-pushed
the
test-path-like
branch
from
e5c9233 to
aded70a
Compare
May 15, 2024 08:56
serhiy-storchaka
force-pushed
the
test-path-like
branch
from
aded70a to
20e44cd
Compare
May 15, 2024 09:26
hauntsaninja
approved these changes
May 16, 2024
hauntsaninja
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Looks good, one comment
Sorry, something went wrong.
Comment thread
Lib/test/test_tarfile.py
Outdated
Copy link
Copy Markdown
|
Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13. |
Sorry, something went wrong.
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
May 16, 2024
…sts (pythonGH-119065) (cherry picked from commit 0152dc4) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
Copy link
Copy Markdown
|
Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.12 due to a conflict. cherry_picker 0152dc4ff5534fa2948b95262e70ff6b202b9b99 3.12 |
Sorry, something went wrong.
Copy link
Copy Markdown
|
GH-119087 is a backport of this pull request to the 3.13 branch. |
Sorry, something went wrong.
serhiy-storchaka
added a commit
to serhiy-storchaka/cpython
that referenced
this pull request
May 16, 2024
…h in tests (pythonGH-119065) (cherry picked from commit 0152dc4) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
Copy link
Copy Markdown
|
GH-119088 is a backport of this pull request to the 3.12 branch. |
Sorry, something went wrong.
serhiy-storchaka
added a commit
to serhiy-storchaka/cpython
that referenced
this pull request
May 16, 2024
…h in tests (pythonGH-119065) (cherry picked from commit 0152dc4) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
Copy link
Copy Markdown
|
GH-119089 is a backport of this pull request to the 3.11 branch. |
Sorry, something went wrong.
serhiy-storchaka
added a commit
to serhiy-storchaka/cpython
that referenced
this pull request
May 16, 2024
…h in tests (pythonGH-119065) (cherry picked from commit 0152dc4) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
serhiy-storchaka
added a commit
that referenced
this pull request
May 16, 2024
Copy link
Copy Markdown
Member
|
These changes will need to be backported to zipp as well. |
Sorry, something went wrong.
serhiy-storchaka
added a commit
that referenced
this pull request
May 16, 2024
jaraco
pushed a commit
to jaraco/zipp
that referenced
this pull request
May 16, 2024
clrpackages
pushed a commit
to clearlinux-pkgs/pypi-zipp
that referenced
this pull request
May 17, 2024
…n 3.18.2
Avasam (1):
Allow mypy on PyPy (jaraco/skeleton#111)
Bartosz Sławecki (2):
Add link to blog entry from jaraco/skeleton#115 above CI build matrix.
Move project metadata to `pyproject.toml` (jaraco/skeleton#122)
Jason R. Coombs (13):
Update compatibility matrix to reflect changes merged in Python 3.12 and anticipated for 3.13.
Re-enable ignoring of temporary merge queue branches. Closes jaraco/skeleton#103.
Fetch unshallow clones in readthedocs. Closes jaraco/skeleton#114.
Move Python 3.11 out of the test matrix.
Configure pytest to support namespace packages. Ref pytest-dev/pytest#12112.
Pin against pytest 8.1.x due to pytest-dev/pytest#12194.
Migrated config to pyproject.toml using jaraco.develop.migrate-config and ini2toml.
Allow macos on Python 3.8 to fail as GitHub CI has dropped support.
Move project.urls to appear in the order that ini2toml generates it. Remove project.scripts.
Revert "Allow macos on Python 3.8 to fail as GitHub CI has dropped support."
Utilize temp_dir from os_helper.
Use an overlay object to make tests appear to use zipfile.Path to reduce diff with CPython.
Finalize
Serhiy Storchaka (1):
gh-119064: Use os_helper.FakePath instead of pathlib.Path in tests (python/cpython#119065)
Xie Yanbo (1):
Fix typo in Lib/zipfile/_path/__init__.py
estyxx
pushed a commit
to estyxx/cpython
that referenced
this pull request
Jul 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.