gh-108267: Fix object.__setattr__ regression in dataclasses docs - #119082
Merged
AlexWaygood merged 1 commit intoMay 16, 2024
Merged
gh-108267: Fix object.__setattr__ regression in dataclasses docs#119082AlexWaygood merged 1 commit into
AlexWaygood merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
AlexWaygood
approved these changes
May 16, 2024
AlexWaygood
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Thanks!
Sorry, something went wrong.
Copy link
Copy Markdown
|
Thanks @hauntsaninja for the PR, and @AlexWaygood for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13. |
Sorry, something went wrong.
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
May 16, 2024
pythonGH-119082) (cherry picked from commit 17cba55) Co-authored-by: Shantanu <12621235+hauntsaninja@users.noreply.github.com>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
May 16, 2024
pythonGH-119082) (cherry picked from commit 17cba55) Co-authored-by: Shantanu <12621235+hauntsaninja@users.noreply.github.com>
Copy link
Copy Markdown
|
GH-119097 is a backport of this pull request to the 3.13 branch. |
Sorry, something went wrong.
Copy link
Copy Markdown
|
GH-119098 is a backport of this pull request to the 3.12 branch. |
Sorry, something went wrong.
AlexWaygood
pushed a commit
that referenced
this pull request
May 16, 2024
AlexWaygood
pushed a commit
that referenced
this pull request
May 16, 2024
estyxx
pushed a commit
to estyxx/cpython
that referenced
this pull request
Jul 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks to FrozenBob for catching (again)!
Unfortunately the regression was backported to 3.11, which is now in security only: #117005 (comment)
📚 Documentation preview 📚: https://cpython-previews--119082.org.readthedocs.build/