[3.12] gh-119049: Fix incorrect display of warning which is constructed by C API (GH-119063) - #119119
Closed
Eclips4 wants to merge 1 commit into
Closed
[3.12] gh-119049: Fix incorrect display of warning which is constructed by C API (GH-119063)#119119Eclips4 wants to merge 1 commit into
Eclips4 wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
…d by C API (pythonGH-119063) The source line was not displayed if the warnings module had not yet been imported.
This was referenced May 17, 2024
serhiy-storchaka
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Humm, the tests are passed with the unmodified code. Does it mean that the issue did not exist in 3.12 or that it was reproducible only when pass the code as a string in 3.13?
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
Indeed, the issue only occurs when passing the code as a string in 3.13+ versions. Backporting this pull request to 3.12 makes no sense, so I'm going to close it. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The source line was not displayed if the warnings module had not yet been imported.