FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-119146: Update `paths` in `jit.yml` by savannahostrowski · Pull Request #119147 · python/cpython · GitHub

/ cpython Public

gh-119146: Update paths in jit.yml - #119147

Merged
brandtbucher merged 7 commits into
python:mainfrom
savannahostrowski:jit-ignore-filews
May 19, 2024
ConversationCommits (7)ChecksFiles changed
Merged

gh-119146: Update paths in jit.yml #119147
brandtbucher merged 7 commits into
python:mainfrom
savannahostrowski:jit-ignore-filews

Conversation

savannahostrowski commented May 18, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

bedevere-app Bot mentioned this pull request May 18, 2024
Closed
erlend-aasland requested a review from hugovk May 18, 2024 15:00
brandtbucher added tests Tests in the Lib/test dir skip news labels May 18, 2024
brandtbucher self-assigned this May 18, 2024
FFY00 approved these changes May 18, 2024
View reviewed changes

FFY00 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

We should actually be able to ignore Python/perf_jit_trampoline.c by using a negative matching pattern: !Python/perf_jit_trampoline.c.

Other than that, looks good to me.

savannahostrowski commented May 18, 2024

Copy link
Copy Markdown
Member Author

Oh! I totally didn't know about that. I'll take a look at adding that when I also add .h files to the paths (since I missed adding those in too).

AlexWaygood reviewed May 18, 2024
View reviewed changes

AlexWaygood left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks! Maybe we could just ignore all .md and .ini files? Then if we added others in the future, we wouldn't have to remember to update this file?

Comment thread .github/workflows/jit.yml Outdated
Comment thread .github/workflows/jit.yml Outdated
savannahostrowski and others added 2 commits May 18, 2024 15:29
Update jit.yml
bf52b3c 
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
Update jit.yml
168bfd0 
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>

savannahostrowski commented May 18, 2024

Copy link
Copy Markdown
Member Author

Yeah, that's a fair callout!

AlexWaygood approved these changes May 18, 2024
View reviewed changes

AlexWaygood left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks!

brandtbucher reviewed May 19, 2024
View reviewed changes
Comment thread .github/workflows/jit.yml Outdated
Update .github/workflows/jit.yml
ce42693 
Co-authored-by: Brandt Bucher <brandtbucher@gmail.com>
brandtbucher enabled auto-merge (squash) May 19, 2024 12:36
brandtbucher merged commit 5307f44 into python:main May 19, 2024

hugovk commented May 20, 2024

Copy link
Copy Markdown
Member

Thanks for the PR!

Shall we backport it, or close the issue?

erlend-aasland commented May 20, 2024

Copy link
Copy Markdown
Contributor

I think it's ok to backport it to 3.13.

brandtbucher added the needs backport to 3.13 bugs and security fixes label May 20, 2024

miss-islington-app Bot commented May 20, 2024

Copy link
Copy Markdown

Thanks @savannahostrowski for the PR, and @brandtbucher for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 20, 2024
pythonGH-119146: Don't run JIT CI on unrelated changes (pythonGH-119147)
80ff420 
(cherry picked from commit 5307f44)

Co-authored-by: Savannah Ostrowski <savannahostrowski@gmail.com>
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>

bedevere-app Bot commented May 20, 2024

Copy link
Copy Markdown

GH-119226 is a backport of this pull request to the 3.13 branch.

bedevere-app Bot removed the needs backport to 3.13 bugs and security fixes label May 20, 2024
This was referenced Jun 12, 2024
Merged
Merged
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
pythonGH-119146: Don't run JIT CI on unrelated changes (pythonGH-119147)
be0335d 
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
savannahostrowski deleted the jit-ignore-filews branch September 27, 2024 16:55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

brandtbucher brandtbucher left review comments
AlexWaygood AlexWaygood approved these changes
FFY00 FFY00 approved these changes
hugovk Awaiting requested review from hugovk

Assignees

brandtbucher

Labels

skip news tests Tests in the Lib/test dir topic-JIT

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL