gh-110383: Document socket.makefile() accepts combined modes - #119150
Merged
erlend-aasland merged 4 commits intoMay 21, 2024
Merged
gh-110383: Document socket.makefile() accepts combined modes#119150erlend-aasland merged 4 commits into
erlend-aasland merged 4 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
|
All commit authors signed the Contributor License Agreement. |
Sorry, something went wrong.
erlend-aasland
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Can you change the docstring in Lib/socket.py as well, so they are synchronised?
Sorry, something went wrong.
erlend-aasland
approved these changes
May 21, 2024
erlend-aasland
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Great, thanks!
Sorry, something went wrong.
erlend-aasland
enabled auto-merge (squash)
May 21, 2024 16:05
This comment was marked as outdated.
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
May 21, 2024
…ythonGH-119150) The supported mode values are 'r', 'w', and 'b', or a combination of those. (cherry picked from commit 62a29be) Co-authored-by: Daniel Williams <dann0a@gmail.com>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
May 21, 2024
…ythonGH-119150) The supported mode values are 'r', 'w', and 'b', or a combination of those. (cherry picked from commit 62a29be) Co-authored-by: Daniel Williams <dann0a@gmail.com>
Copy link
Copy Markdown
|
GH-119324 is a backport of this pull request to the 3.13 branch. |
Sorry, something went wrong.
Copy link
Copy Markdown
|
GH-119325 is a backport of this pull request to the 3.12 branch. |
Sorry, something went wrong.
erlend-aasland
pushed a commit
that referenced
this pull request
May 21, 2024
…GH-119150) (#119324) The supported mode values are 'r', 'w', and 'b', or a combination of those. (cherry picked from commit 62a29be) Co-authored-by: Daniel Williams <dann0a@gmail.com>
erlend-aasland
pushed a commit
that referenced
this pull request
May 21, 2024
…GH-119150) (#119325) The supported mode values are 'r', 'w', and 'b', or a combination of those. (cherry picked from commit 62a29be) Co-authored-by: Daniel Williams <dann0a@gmail.com>
estyxx
pushed a commit
to estyxx/cpython
that referenced
this pull request
Jul 17, 2024
…ython#119150) The supported mode values are 'r', 'w', and 'b', or a combination of those.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ref: #110383
ref: https://mail.python.org/archives/list/docs@python.org/thread/3VGLA6Q6QDYB7XIAHFIRAVW4TQSEAZGA/
📚 Documentation preview 📚: https://cpython-previews--119150.org.readthedocs.build/