FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Fix version number in use_load_tests deprecation reference by jacobtylerwalls · Pull Request #119151 · python/cpython · GitHub

/ cpython Public

Fix version number in use_load_tests deprecation reference - #119151

Merged
serhiy-storchaka merged 1 commit into
python:mainfrom
jacobtylerwalls:fix-deprecation-reference
May 22, 2024
ConversationCommits (1)ChecksFiles changed
Merged

Fix version number in use_load_tests deprecation reference#119151
serhiy-storchaka merged 1 commit into
python:mainfrom
jacobtylerwalls:fix-deprecation-reference

Conversation

jacobtylerwalls commented May 18, 2024 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Contributor

Deprecation took place in d78742a (3.5)

📚 Documentation preview 📚: https://cpython-previews--119151.org.readthedocs.build/

bedevere-app Bot added docs Documentation in the Doc dir skip news awaiting review labels May 18, 2024
blaisep reviewed May 20, 2024
View reviewed changes

blaisep left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Nice catch,
...there is a directive called .. deprecated:: which might be useful here.

Comment thread Doc/whatsnew/3.12.rst
* Undocumented :meth:`TestLoader.loadTestsFromModule
<unittest.TestLoader.loadTestsFromModule>` parameter *use_load_tests*
(deprecated and ignored since Python 3.2).
(deprecated and ignored since Python 3.5).

blaisep May 20, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Nice catch thank you.
Could you put this in a .. deprecated:: 3.5 directive ?

jacobtylerwalls May 20, 2024

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks for taking a look. I only see uses of that directive in the actual documentation relating to the method itself, not here in the changelog. I'm reluctant to add the first such directive in this /whatsnew directory.

blaisep May 21, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Fair enough. I guess this may be impacted by the bigger topic mentioned in #109843 (comment) having to do with moving deprecation and removal items out of news.

Comment thread Doc/whatsnew/3.12.rst
(deprecated and ignored since Python 3.5).

* An alias of the :class:`~unittest.TextTestResult` class:
``_TextTestResult`` (deprecated in Python 3.2).

blaisep May 20, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This might also be a candidate for ..deprecated :: 3.2

serhiy-storchaka approved these changes May 22, 2024
View reviewed changes

serhiy-storchaka left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM.

serhiy-storchaka merged commit aee8f03 into python:main May 22, 2024

miss-islington-app Bot commented May 22, 2024

Copy link
Copy Markdown

Thanks @jacobtylerwalls for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 22, 2024
Fix version number in use_load_tests deprecation reference (pythonGH-…
f89fc31 
…119151)

Deprecation took place in d78742a (3.5)
(cherry picked from commit aee8f03)

Co-authored-by: Jacob Walls <jacobtylerwalls@gmail.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 22, 2024
Fix version number in use_load_tests deprecation reference (pythonGH-…
34bd528 
…119151)

Deprecation took place in d78742a (3.5)
(cherry picked from commit aee8f03)

Co-authored-by: Jacob Walls <jacobtylerwalls@gmail.com>

bedevere-app Bot commented May 22, 2024

Copy link
Copy Markdown

GH-119386 is a backport of this pull request to the 3.13 branch.

bedevere-app Bot removed the needs backport to 3.13 bugs and security fixes label May 22, 2024

bedevere-app Bot commented May 22, 2024

Copy link
Copy Markdown

GH-119387 is a backport of this pull request to the 3.12 branch.

bedevere-app Bot removed the needs backport to 3.12 only security fixes label May 22, 2024
serhiy-storchaka pushed a commit that referenced this pull request May 22, 2024
[3.12] Fix version number in use_load_tests deprecation reference (GH…
2c7e9de 
…-119151) (GH-119387)

Deprecation took place in d78742a (3.5)
(cherry picked from commit aee8f03)

Co-authored-by: Jacob Walls <jacobtylerwalls@gmail.com>
serhiy-storchaka pushed a commit that referenced this pull request May 22, 2024
[3.13] Fix version number in use_load_tests deprecation reference (GH…
414346e 
…-119151) (GH-119386)

Deprecation took place in d78742a (3.5)
(cherry picked from commit aee8f03)

Co-authored-by: Jacob Walls <jacobtylerwalls@gmail.com>
jacobtylerwalls deleted the fix-deprecation-reference branch May 22, 2024 10:14
JelleZijlstra mentioned this pull request May 28, 2024
Closed
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
Fix version number in use_load_tests deprecation reference (pythonGH-…
8f1b9d9 
…119151)

Deprecation took place in d78742a (3.5)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

serhiy-storchaka serhiy-storchaka approved these changes
+1 more reviewer
blaisep blaisep left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL