GH-119169: Speed up os.walk(topdown=False) - #119186
Closed
barneygale wants to merge 12 commits into
Closed
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Handle errors from `os.scandir()` and `ScandirIterator` similarly, which lets us loop over directory entries with `for`. In top-down mode, call `os.path.join()` at most once per iteration.
Copy link
Copy Markdown
Member
Sorry, something went wrong.
barneygale
marked this pull request as draft
May 23, 2024 08:46
Copy link
Copy Markdown
Contributor
Author
|
#119473 fixes the test failure. |
Sorry, something went wrong.
barneygale
added a commit
to barneygale/cpython
that referenced
this pull request
Jul 6, 2024
When `os.walk()` traverses into subdirectories in top-down mode, call `os.path.join()` once to add a trailing slash, and use string concatenation thereafter to generate child paths.
barneygale
added a commit
to barneygale/cpython
that referenced
this pull request
Jul 6, 2024
Handle errors from `os.scandir()` and `ScandirIterator` similarly, which lets us loop over directory entries with `for`.
barneygale
added a commit
to barneygale/cpython
that referenced
this pull request
Jul 8, 2024
Copy link
Copy Markdown
Contributor
Author
|
Closing because reversing sibling traversal order isn't kosher - see discussion on #119473. |
Sorry, something went wrong.
encukou
added a commit
to barneygale/cpython
that referenced
this pull request
Sep 2, 2025
encukou
pushed a commit
that referenced
this pull request
Sep 3, 2025
GH-119186: Slightly speed up `os.walk(topdown=True)` When `os.walk()` traverses into subdirectories in top-down mode, call `os.path.join()` once to add a trailing slash, and use string concatenation thereafter to generate child paths.
lkollar
pushed a commit
to lkollar/cpython
that referenced
this pull request
Sep 9, 2025
…121431) pythonGH-119186: Slightly speed up `os.walk(topdown=True)` When `os.walk()` traverses into subdirectories in top-down mode, call `os.path.join()` once to add a trailing slash, and use string concatenation thereafter to generate child paths.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add entries to the stack while iterating over os.scandir() results, rather than afterwards.