gh-119292: Add job to jit.yml to build and test with --disable-gil - #119293
gh-119292: Add job to jit.yml to build and test with --disable-gil#119293brandtbucher merged 10 commits into
Conversation
Sorry, something went wrong.
|
I also think I messed up the issue tagging bot by adding my PR comment after opening the PR...not sure how to fix that? Copy paste saves the day? |
Sorry, something went wrong.
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
|
I suppose this could also be implemented as a matrix entry using include. For now, I feel like a new job is probably simpler because we're only testing a single platform, but if we ever want to expand the tested platforms, we could consider moving in that direction to avoid a ton of duplication. |
Sorry, something went wrong.
| - name: Build with JIT enabled and GIL disabled | ||
| run: | | ||
| sudo bash -c "$(wget -O - https://apt.llvm.org/llvm.sh)" ./llvm.sh 18 | ||
| export PATH="$(llvm-config-18 --bindir):$PATH" |
There was a problem hiding this comment.
Opinions: should we add --with-pydebug? Maybe test both modes?
Sorry, something went wrong.
There was a problem hiding this comment.
I think it's fine to leave this as-is (just one --with-pydebug build).
Sorry, something went wrong.
brandtbucher
left a comment
There was a problem hiding this comment.
Great idea.
One suggestion:
Sorry, something went wrong.
Co-authored-by: Brandt Bucher <brandtbucher@gmail.com>
|
Thanks @savannahostrowski for the PR, and @brandtbucher for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13. |
Sorry, something went wrong.
…il (pythonGH-119293) (cherry picked from commit c4722cd) Co-authored-by: Savannah Ostrowski <savannahostrowski@gmail.com> Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
|
GH-119314 is a backport of this pull request to the 3.13 branch. |
Sorry, something went wrong.
…il (pythonGH-119293) Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
Alrighty, so I added a very basic job to test that we don't regress things as the JIT and free threading work evolves. I split the build and test into separate steps, so we have a little finer granularity on failures (it's just slightly prettier!). I also opted not to use strategy/matrix to pass in the LLVM version since we only support 18 today. I can add that in if folks feel strongly if we want to keep things very consistent with the other job, but I was going for simple 😄