FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-119357: Increase test coverage for keymap in _pyrepl by eugenetriguba · Pull Request #119358 · python/cpython · GitHub

/ cpython Public

gh-119357: Increase test coverage for keymap in _pyrepl - #119358

Merged
ambv merged 4 commits into
python:mainfrom
eugenetriguba:gh-119357
May 22, 2024
ConversationCommits (4)ChecksFiles changed
Merged

gh-119357: Increase test coverage for keymap in _pyrepl#119358
ambv merged 4 commits into
python:mainfrom
eugenetriguba:gh-119357

Conversation

eugenetriguba commented May 21, 2024 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor

This PR adds a few test cases to the keymap module tests to increase the coverage.

Lib/_pyrepl/keymap.py                 79      0     48      0   100%

bedevere-app Bot mentioned this pull request May 21, 2024
Closed
eugenetriguba commented May 21, 2024
View reviewed changes
Comment thread Lib/_pyrepl/completing_reader.py
# types
Command = commands.Command
if False:
from .types import Callback, SimpleContextManager, KeySpec, CommandName

eugenetriguba May 21, 2024

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

note: these two aren't used

eugenetriguba commented May 21, 2024

Copy link
Copy Markdown
Contributor Author

I'd think this PR can skip news

ambv added skip news topic-repl Related to the interactive shell labels May 21, 2024
ambv reviewed May 21, 2024
View reviewed changes
Comment thread Lib/_pyrepl/keymap.py Outdated

eugenetriguba commented May 21, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

@ambv beat me to it, thanks for the fix 🙂 I'll update the issue to more clearly encompass all of PyREPL instead of just the keymap module. Thanks for the feedback, let me know if you had any other requested changes!

ambv merged commit 73ab83b into python:main May 22, 2024
lysnikolaou added the needs backport to 3.13 bugs and security fixes label May 22, 2024

miss-islington-app Bot commented May 22, 2024

Copy link
Copy Markdown

Thanks @eugenetriguba for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington-app Bot commented May 22, 2024

Copy link
Copy Markdown

Sorry, @eugenetriguba and @ambv, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 73ab83b27f105a4509046ce26e35f20d66625195 3.13

lysnikolaou pushed a commit to lysnikolaou/cpython that referenced this pull request May 22, 2024
[3.13] pythongh-119357: Increase test coverage for keymap in _pyrepl (p…
f509295 
…ythonGH-119358)

(cherry picked from commit 73ab83b)

Co-authored-by: Eugene Triguba <eugenetriguba@gmail.com>
Co-authored-by: Łukasz Langa <lukasz@langa.pl>

bedevere-app Bot commented May 22, 2024

Copy link
Copy Markdown

GH-119414 is a backport of this pull request to the 3.13 branch.

bedevere-app Bot removed the needs backport to 3.13 bugs and security fixes label May 22, 2024
ambv added a commit that referenced this pull request May 22, 2024
[3.13] gh-119357: Increase test coverage for keymap in _pyrepl (GH-11…
e6e4efc 
…9358) (#119414)

(cherry picked from commit 73ab83b)

Co-authored-by: Eugene Triguba <eugenetriguba@gmail.com>
Co-authored-by: Łukasz Langa <lukasz@langa.pl>
JelleZijlstra mentioned this pull request May 28, 2024
Closed
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
pythongh-119357: Increase test coverage for keymap in _pyrepl (python…
78a44a9 
…#119358)

Co-authored-by: Łukasz Langa <lukasz@langa.pl>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

ambv ambv left review comments

Assignees

ambv

Labels

skip news topic-repl Related to the interactive shell

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL