DOCS: fix error in exec namespace note - #119378
Conversation
Sorry, something went wrong.
When updating the new exec note added in pythongh-119235 as part of the PEP 667 general docs PR, I suggested a workaround that isn't valid. Since it's far from the first time I've considered that workaround, and the fact it doesn't work has surprised me every time, amend the new note to explicitly state that dict merging is the only option.
|
Only backporting to 3.13, since the incorrect workaround was never added to the 3.12 note. |
Sorry, something went wrong.
gvanrossum
left a comment
There was a problem hiding this comment.
I would
Just delete the incorrect workaround. It doesn’t seem very valuable to explicitly document something that doesn’t work, nor the cumbersome copying.
Sorry, something went wrong.
|
Good point, done (and set to merge once CI is happy). |
Sorry, something went wrong.
|
Thanks @ncoghlan for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13. |
Sorry, something went wrong.
When updating the new exec note added in pythongh-119235 as part of the PEP 667 general docs PR, I suggested a workaround that isn't valid. The first half of the note is still reasonable, so just omit the invalid text. (cherry picked from commit 31d61a7) Co-authored-by: Alyssa Coghlan <ncoghlan@gmail.com>
|
GH-119380 is a backport of this pull request to the 3.13 branch. |
Sorry, something went wrong.
When updating the new exec note added in pythongh-119235 as part of the PEP 667 general docs PR, I suggested a workaround that isn't valid. The first half of the note is still reasonable, so just omit the invalid text.
When updating the new exec note added in gh-119235 as part of the PEP 667 general docs PR, I suggested a workaround that isn't valid.
Since it's far from the first time I've considered that workaround, and the fact it doesn't work has surprised me every time, amend the new note to explicitly state that dict merging is the only option.
📚 Documentation preview 📚: https://cpython-previews--119378.org.readthedocs.build/