FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-119180: Update the magic number by JelleZijlstra · Pull Request #119397 · python/cpython · GitHub

/ cpython Public

gh-119180: Update the magic number - #119397

Merged
JelleZijlstra merged 2 commits into
python:mainfrom
JelleZijlstra:pep649-magic
May 25, 2024
ConversationCommits (2)ChecksFiles changed
Merged

gh-119180: Update the magic number#119397
JelleZijlstra merged 2 commits into
python:mainfrom
JelleZijlstra:pep649-magic

Conversation

JelleZijlstra commented May 22, 2024 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

PR #119321 added a comment about the magic number bump
but did not actually apply the new magic number.

Also, update PC/launcher.c.

pythongh-119180: Update the magic number
eae04ad 
but did not actually apply the new magic number.
Update launcher.c
889d12f
JelleZijlstra requested a review from ambv May 22, 2024 12:46
bedevere-app Bot mentioned this pull request May 22, 2024
Closed
30 tasks

Eclips4 commented May 22, 2024

Copy link
Copy Markdown
Member

I've probably found a typo:

cpython/Lib/importlib/_bootstrap_external.py

Line 475 in d472b4f

# Python 3.14a1 3600 (Add LOAD_COMMON_CONSTANT)

Since we are at a0 now, there's should be 3.14a0, isn't it?
If so, I think we can address that in this PR :)

JelleZijlstra commented May 22, 2024

Copy link
Copy Markdown
Member Author

a1 is right; the change is expected to be released in a1. You can see a little further up that there were numerous changes listed as 3.13a1 but none for 3.13a0.

Eclips4 commented May 22, 2024

Copy link
Copy Markdown
Member

a1 is right; the change is expected to be released in a1. You can see a little further up that there were numerous changes listed as 3.13a1 but none for 3.13a0.

I was confused by an older entries where's a0 is used:

cpython/Lib/importlib/_bootstrap_external.py

Lines 354 to 356 in c9073eb

# Python 3.9a0 3420 (add LOAD_ASSERTION_ERROR #34880)
# Python 3.9a0 3421 (simplified bytecode for with blocks #32949)
# Python 3.9a0 3422 (remove BEGIN_FINALLY, END_FINALLY, CALL_FINALLY, POP_FINALLY bytecodes #33387)

It seems that the policy has changed since then?

JelleZijlstra merged commit 84be524 into python:main May 25, 2024
JelleZijlstra deleted the pep649-magic branch May 25, 2024 00:32
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
pythongh-119180: Update the magic number (python#119397)
1c6cb41 
PR python#119321 added a comment about the magic number bump
but did not actually apply the new magic number.
JelleZijlstra restored the pep649-magic branch September 10, 2024 23:37
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

ambv Awaiting requested review from ambv
brettcannon Awaiting requested review from brettcannon brettcannon is a code owner
ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner
ncoghlan Awaiting requested review from ncoghlan ncoghlan is a code owner
warsaw Awaiting requested review from warsaw warsaw is a code owner

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL