gh-119469: Fix _pyrepl reference leaks - #119470
Merged
ambv merged 1 commit intoMay 23, 2024
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
vstinner
approved these changes
May 23, 2024
vstinner
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM.
I confirm that this change fix the issue:
$ ./python -m test test_pyrepl -u all -R 3:3 (...) Result: SUCCESS
Sorry, something went wrong.
lysnikolaou
approved these changes
May 23, 2024
lysnikolaou
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM!
Sorry, something went wrong.
Copy link
Copy Markdown
|
Thanks @ambv for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13. |
Sorry, something went wrong.
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
May 23, 2024
(cherry picked from commit 6e012ce) Co-authored-by: Łukasz Langa <lukasz@langa.pl>
Copy link
Copy Markdown
|
GH-119471 is a backport of this pull request to the 3.13 branch. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Co-authored-by: Victor Stinner vstinner@python.org