FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Update README and layout.html from 3.13 to 3.14 by Wulian233 · Pull Request #119539 · python/cpython · GitHub

/ cpython Public

Update README and layout.html from 3.13 to 3.14 - #119539

Merged
hugovk merged 16 commits into
python:mainfrom
Wulian233:readme
May 26, 2024
Merged

Update README and layout.html from 3.13 to 3.14#119539
hugovk merged 16 commits into
python:mainfrom
Wulian233:readme

Conversation

Wulian233 commented May 25, 2024
edited
Loading

Copy link
Copy Markdown
Contributor

Skip issue and news


📚 Documentation preview 📚: https://cpython-previews--119539.org.readthedocs.build/

Wulian233 commented May 25, 2024
edited
Loading

Copy link
Copy Markdown
Contributor Author

Oh NO. There was an accident, my last not merge PR changed files was added here

I was revert it, unittestgui.py looks no change, but show in file changed list

Copy link
Copy Markdown
Contributor

I think we can add skip issue and news.

Wulian233 commented May 25, 2024
edited
Loading

Copy link
Copy Markdown
Contributor Author

I'm not sure layout.html should keep 3.13(dev), I deleted (dev) to 3.13

Comment thread Doc/tools/templates/layout.html Outdated
Co-authored-by: Nice Zombies <nineteendo19d0@gmail.com>

Copy link
Copy Markdown
Contributor Author

See #119541
layout.html -> js
Do the layout.html changes here need cancel? Add 3.14 in the #119541 ?

Copy link
Copy Markdown
Contributor

You can wait to see which pull request is merged first.

hugovk commented May 25, 2024

Copy link
Copy Markdown
Member

unittestgui.py looks no change, but show in file changed list

Please delete unittestgui.py from the PR, or I can do it for you if you like?

See #119541 layout.html -> js
Do the layout.html changes here need cancel?
Add 3.14 in the #119541 ?

It makes more sense to add 3.14 to layout.html here, so #119541 is just moving code, not adding to it. We can resolve conflicts later.

Wulian233 commented May 25, 2024
edited
Loading

Copy link
Copy Markdown
Contributor Author

unittestgui.py looks no change, but show in file changed list

Please delete unittestgui.py from the PR, or I can do it for you if you like?

Can you help me delete the unittestgui.py, thx☺️

hugovk commented May 25, 2024

Copy link
Copy Markdown
Member

Done, or rather what was needed was to re-add the x permission.

Copy link
Copy Markdown
Contributor

Ah wow, '100644' -> '100755' is the change in the mode of the file.
Wouldn't '-rw-r--r--' -> '-rwxr-xr-x' be more readable?

Copy link
Copy Markdown
Member

Remove idlelib/help.html from this PR. The change is wrong. I presume you can just revert the corresponding commit.

I believe your DPI commit was included because you made the change to main rather than a dpi branch.

Wulian233 commented May 25, 2024
edited
Loading

Copy link
Copy Markdown
Contributor Author

Yes I made the change to main instead dpi branch:( and I have revert the help.html

Copy link
Copy Markdown
Member

@hugovk Can you either handle this or ping someone else?

Comment thread README.rst Outdated
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
Comment thread README.rst Outdated
hugovk changed the title Update Readme and others from 3.13 to 3.14 Update README and layout.html from 3.13 to 3.14 May 26, 2024
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>

hugovk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks!

hugovk enabled auto-merge (squash) May 26, 2024 11:24
hugovk merged commit b5b7dc9 into python:main May 26, 2024
Wulian233 deleted the readme branch July 2, 2024 13:41
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
Co-authored-by: Nice Zombies <nineteendo19d0@gmail.com>
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants


Back | FazBrowse Home | New Git URL