GH-89727: Partially fix shutil.rmtree() recursion error on deep trees - #119634
Merged
barneygale merged 7 commits intoMay 29, 2024
Merged
GH-89727: Partially fix shutil.rmtree() recursion error on deep trees#119634barneygale merged 7 commits into
barneygale merged 7 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
…ep trees Make `shutil._rmtree_unsafe()` call `os.walk()`, which is implemented without recursion. `shutil._rmtree_safe_fd()` is not affected and can still raise a recursion error.
Copy link
Copy Markdown
Contributor
Author
|
I've added the 'skip news' label because this is only a partial fix. Hopefully that's right! |
Sorry, something went wrong.
JelleZijlstra
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Thanks. I think this should have a NEWS entry since it does change a user-visible behavior.
Sorry, something went wrong.
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
JelleZijlstra
approved these changes
May 29, 2024
Comment thread
Misc/NEWS.d/next/Library/2024-05-29-20-42-17.gh-issue-89727.5lPTTW.rst
Outdated
…PTTW.rst Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
Copy link
Copy Markdown
Contributor
Author
|
Thank you Jelle! |
Sorry, something went wrong.
barneygale
enabled auto-merge (squash)
May 29, 2024 19:49
Copy link
Copy Markdown
|
Thanks @barneygale for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13. |
Sorry, something went wrong.
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
May 29, 2024
…ep trees (pythonGH-119634) Make `shutil._rmtree_unsafe()` call `os.walk()`, which is implemented without recursion. `shutil._rmtree_safe_fd()` is not affected and can still raise a recursion error. (cherry picked from commit a150679) Co-authored-by: Barney Gale <barney.gale@gmail.com> Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
Copy link
Copy Markdown
|
Sorry, @barneygale, I could not cleanly backport this to 3.12 due to a conflict. cherry_picker a150679f90c6e3f017bd75cac3b8f727063cc4aa 3.12 |
Sorry, something went wrong.
Copy link
Copy Markdown
|
GH-119748 is a backport of this pull request to the 3.13 branch. |
Sorry, something went wrong.
barneygale
added a commit
to barneygale/cpython
that referenced
this pull request
May 29, 2024
…ep trees (python#119634) Make `shutil._rmtree_unsafe()` call `os.walk()`, which is implemented without recursion. `shutil._rmtree_safe_fd()` is not affected and can still raise a recursion error. Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com> (cherry picked from commit a150679)
barneygale
added a commit
to barneygale/cpython
that referenced
this pull request
May 29, 2024
…r on deep trees (pythonGH-119634) Make `shutil._rmtree_unsafe()` call `os.walk()`, which is implemented without recursion. `shutil._rmtree_safe_fd()` is not affected and can still raise a recursion error. Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>. (cherry picked from commit a150679) Co-authored-by: Barney Gale <barney.gale@gmail.com>
Copy link
Copy Markdown
|
GH-119749 is a backport of this pull request to the 3.12 branch. |
Sorry, something went wrong.
barneygale
added a commit
that referenced
this pull request
May 29, 2024
…eep trees (GH-119634) (#119748) GH-89727: Partially fix `shutil.rmtree()` recursion error on deep trees (GH-119634) Make `shutil._rmtree_unsafe()` call `os.walk()`, which is implemented without recursion. `shutil._rmtree_safe_fd()` is not affected and can still raise a recursion error. (cherry picked from commit a150679) Co-authored-by: Barney Gale <barney.gale@gmail.com> Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
barneygale
added a commit
that referenced
this pull request
May 29, 2024
…eep trees (GH-119634) (#119749) * GH-89727: Partially fix `shutil.rmtree()` recursion error on deep trees (#119634) Make `shutil._rmtree_unsafe()` call `os.walk()`, which is implemented without recursion. `shutil._rmtree_safe_fd()` is not affected and can still raise a recursion error. Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com> (cherry picked from commit a150679)
noahbkim
pushed a commit
to hudson-trading/cpython
that referenced
this pull request
Jul 11, 2024
…ep trees (python#119634) Make `shutil._rmtree_unsafe()` call `os.walk()`, which is implemented without recursion. `shutil._rmtree_safe_fd()` is not affected and can still raise a recursion error. Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
estyxx
pushed a commit
to estyxx/cpython
that referenced
this pull request
Jul 17, 2024
…ep trees (python#119634) Make `shutil._rmtree_unsafe()` call `os.walk()`, which is implemented without recursion. `shutil._rmtree_safe_fd()` is not affected and can still raise a recursion error. Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
Assignees
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make shutil._rmtree_unsafe() call os.walk(), which is implemented without recursion.
shutil._rmtree_safe_fd() is not affected and can still raise a recursion error.