gh-117398: gh-119655: datetime: Init static state once & don't free it - #119662
Merged
encukou merged 3 commits intoMay 28, 2024
Merged
gh-117398: gh-119655: datetime: Init static state once & don't free it#119662encukou merged 3 commits into
encukou merged 3 commits into
Conversation
This was referenced May 28, 2024
vstinner
reviewed
May 28, 2024
Comment thread
Modules/_datetimemodule.c
| } | ||
| // (capsule == NULL) {is handled by PyModule_Add | ||
| if (PyModule_Add(module, "datetime_CAPI", capsule) < 0) { | ||
| PyMem_Free(capi); |
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
It's not correct to free capi here?
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
There was a problem hiding this comment.
capi is static, we should not free it.
Sorry, something went wrong.
ericsnowcurrently
approved these changes
May 28, 2024
ericsnowcurrently
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
Comment thread
Modules/_datetimemodule.c
Outdated
Comment on lines
+7009
to
+7020
| PyMem_Free(capi); | ||
| goto error; | ||
| } | ||
| // (capsule == NULL) {is handled by PyModule_Add |
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
typo:
// (capsule == NULL) is handled by PyModule_Add.
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
I'll take care of backporting this to 3.13 (by adding it into gh-119641). |
Sorry, something went wrong.
encukou
commented
May 28, 2024
Comment thread
Modules/_datetimemodule.c
Outdated
Copy link
Copy Markdown
⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️Hi! The buildbot AMD64 FreeBSD 3.x has failed when building commit a89fc26. What do you need to do:
You can take a look at the buildbot page here: https://buildbot.python.org/all/#builders/1223/builds/3218 Failed tests:
Failed subtests:
Summary of the results of the build (if available): == Click to see traceback logsTraceback (most recent call last):
File "/buildbot/buildarea/3.x.ware-freebsd/build/Lib/test/test_ssl.py", line 2225, in test_get_server_certificate_ipv6
_test_get_server_certificate(self, 'ipv6.google.com', 443)
~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/buildbot/buildarea/3.x.ware-freebsd/build/Lib/test/test_ssl.py", line 2230, in _test_get_server_certificate
pem = ssl.get_server_certificate((host, port))
File "/buildbot/buildarea/3.x.ware-freebsd/build/Lib/ssl.py", line 1514, in get_server_certificate
with create_connection(addr, timeout=timeout) as sock:
~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^
File "/buildbot/buildarea/3.x.ware-freebsd/build/Lib/socket.py", line 828, in create_connection
for res in getaddrinfo(host, port, 0, SOCK_STREAM):
~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/buildbot/buildarea/3.x.ware-freebsd/build/Lib/socket.py", line 963, in getaddrinfo
for res in _socket.getaddrinfo(host, port, family, type, proto, flags):
~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
socket.gaierror: [Errno 1] Address family for hostname not supported
|
Sorry, something went wrong.
ericsnowcurrently
pushed a commit
to ericsnowcurrently/cpython
that referenced
this pull request
May 28, 2024
…don't free it (pythonGH-119662) - While datetime uses global state, only initialize it once. - While `capi` is static, don't free it (thanks @neonene in https://github.com/python/cpython/pull/119641/files#r1616710048)
Copy link
Copy Markdown
Contributor
|
Thanks! |
Sorry, something went wrong.
estyxx
pushed a commit
to estyxx/cpython
that referenced
this pull request
Jul 17, 2024
…don't free it (pythonGH-119662) - While datetime uses global state, only initialize it once. - While `capi` is static, don't free it (thanks @neonene in https://github.com/python/cpython/pull/119641/files#r1616710048)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.