gh-126782: Support qualified referencing for ntpath.abspath() - #119849
Closed
nineteendo wants to merge 12 commits into
Closed
gh-126782: Support qualified referencing for ntpath.abspath()#119849nineteendo wants to merge 12 commits into
nineteendo wants to merge 12 commits into
Conversation
nineteendo
marked this pull request as ready for review
May 31, 2024 13:34
…2-44-38.gh-issue-119826.Atm9ol.rst
This comment was marked as outdated.
This comment was marked as outdated.
nineteendo
force-pushed
the
fix-ntpath.abspath
branch
from
e1d709e to
335a737
Compare
October 14, 2024 19:34
nineteendo
requested review from
a team,
JelleZijlstra,
barneygale,
brettcannon,
corona10,
ericsnowcurrently,
erlend-aasland,
ethanfurman,
freakboy3742,
jaraco and
willingc
as code owners
November 13, 2024 07:23
erlend-aasland
removed request for
1st1,
JelleZijlstra,
abalkin,
asvetlov,
brettcannon,
carljm,
corona10,
ericsnowcurrently,
ethanfurman,
gpshead,
hugovk,
iritkatriel,
jaraco,
markshannon,
methane,
ncoghlan,
pablogsal,
pganssle,
rhettinger,
tiran,
vsajip,
warsaw and
willingc
November 13, 2024 07:31
Copy link
Copy Markdown
Contributor
Author
|
I never rebase, when I force push it's to redo a merge commit which failed here. |
Sorry, something went wrong.
…024-05-31-12-44-38.gh-issue-126782.Atm9ol.rst
Copy link
Copy Markdown
Contributor
Author
|
I'll fix the drive relative paths in a separate PR. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Two notes:
|
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
Sorry for the chaos. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
It wasn't a rebase, I made a merge commit locally, but I realised I forgot to add the generated code. So I reset my head and committed without restarting the merge, causing the reviews to be requested. I force pushed afterwards to revert this commit in the hope it would remove the reviews (it didn't) with the intention of trying again. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.