FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-119853: Add Include/refcount.h file by vstinner · Pull Request #119854 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

gh-119853: Add Include/refcount.h file - #119854

Merged
vstinner merged 1 commit into
python:mainfrom
vstinner:refcount
May 31, 2024
ConversationCommits (1)ChecksFiles changed
Merged

gh-119853: Add Include/refcount.h file #119854
vstinner merged 1 commit into
python:mainfrom
vstinner:refcount

Conversation

vstinner commented May 31, 2024 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

vstinner commented May 31, 2024

Copy link
Copy Markdown
Member Author

cc @colesbury @corona10

vstinner mentioned this pull request May 31, 2024
Closed
corona10 approved these changes May 31, 2024
View reviewed changes

corona10 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

lgtm

vstinner commented May 31, 2024

Copy link
Copy Markdown
Member Author
  • Python.h includes object.h before refcount.h.
  • object.h refers to 2 macros defined in refcount.h: PyObject_HEAD_INIT refers to _Py_IMMORTAL_REFCNT_LOCAL and PyObject_HEAD_INIT refers to _Py_IMMORTAL_REFCNT. It works since the macro is not expanded before refcount.h is included.

vstinner commented May 31, 2024

Copy link
Copy Markdown
Member Author

I prefer to not backport this change to 3.13, but it can make backport from 3.14 to 3.13 more complicated (doable, it's just more manual work if Git fails to track code move).

corona10 commented May 31, 2024

Copy link
Copy Markdown
Member

IMO, Backporting to 3.13 is worth doing it since we modified a lot of code at 3.13

vstinner commented May 31, 2024

Copy link
Copy Markdown
Member Author

IMO, Backporting to 3.13 is worth doing it since we modified a lot of code at 3.13

IMO it's too later after beta1.

vstinner changed the title gh-119853: Add Include/refcount.h file gh-119853: Add Include/refcount.h file May 31, 2024
vstinner changed the title gh-119853: Add Include/refcount.h file gh-119853: Add Include/refcount.h file May 31, 2024
vstinner merged commit 891c1e3 into python:main May 31, 2024
vstinner deleted the refcount branch May 31, 2024 14:49

vstinner commented May 31, 2024

Copy link
Copy Markdown
Member Author

Merged, thanks for the review. I don't plan to backport the change to 3.13 since we are past the feature freeze.

vstinner commented May 31, 2024

Copy link
Copy Markdown
Member Author

Oh, I forgot to add the header file to projects: #119860

noahbkim pushed a commit to hudson-trading/cpython that referenced this pull request Jul 11, 2024
pythongh-119853: Add Include/refcount.h file (python#119854)
2755a74
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
pythongh-119853: Add Include/refcount.h file (python#119854)
d4da881
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

colesbury colesbury approved these changes
corona10 corona10 approved these changes

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL