gh-119180: Lazily wrap annotations on classmethod and staticmethod - #119864
Merged
JelleZijlstra merged 1 commit intoMay 31, 2024
Merged
gh-119180: Lazily wrap annotations on classmethod and staticmethod#119864JelleZijlstra merged 1 commit into
JelleZijlstra merged 1 commit into
Conversation
30 tasks
carljm
approved these changes
May 31, 2024
Copy link
Copy Markdown
Member
|
Hmm, what's the plan for functools.update_wrapper? Some kind of pure-Python version of this descriptor, that lazily queries the original __annotations__? |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
If the wrapper is a Python function, we can just copy over __annotate__, and the __annotations__ descriptor will know to call the __annotate__. If the wrapper is not a Python function, I'm not sure yet. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
@AlexWaygood I implemented this in JelleZijlstra@672511a |
Sorry, something went wrong.
noahbkim
pushed a commit
to hudson-trading/cpython
that referenced
this pull request
Jul 11, 2024
estyxx
pushed a commit
to estyxx/cpython
that referenced
this pull request
Jul 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.