gh-117657: Fix TSAN race in QSBR assertion - #119887
Merged
colesbury merged 2 commits intoJun 1, 2024
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Due to a limitation in TSAN, all reads from PyThreadState.state must be atomic to avoid reported races.
Fidget-Spinner
approved these changes
Jun 1, 2024
Copy link
Copy Markdown
|
Thanks @colesbury for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13. |
Sorry, something went wrong.
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jun 1, 2024
Due to a limitation in TSAN, all reads from `PyThreadState.state` must be atomic to avoid reported races. (cherry picked from commit 90ec19f) Co-authored-by: Sam Gross <colesbury@gmail.com>
Copy link
Copy Markdown
|
GH-119904 is a backport of this pull request to the 3.13 branch. |
Sorry, something went wrong.
colesbury
added a commit
that referenced
this pull request
Jun 1, 2024
Copy link
Copy Markdown
Contributor
|
Don't we want to use the FT_ATOMIC_LOAD_* macro from pycore_pyatomic_ft_wrappers.h to avoid affecting the GIL code? |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
No:
|
Sorry, something went wrong.
barneygale
pushed a commit
to barneygale/cpython
that referenced
this pull request
Jun 5, 2024
Due to a limitation in TSAN, all reads from `PyThreadState.state` must be atomic to avoid reported races.
noahbkim
pushed a commit
to hudson-trading/cpython
that referenced
this pull request
Jul 11, 2024
Due to a limitation in TSAN, all reads from `PyThreadState.state` must be atomic to avoid reported races.
estyxx
pushed a commit
to estyxx/cpython
that referenced
this pull request
Jul 17, 2024
Due to a limitation in TSAN, all reads from `PyThreadState.state` must be atomic to avoid reported races.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to a limitation of TSAN, all reads from PyThreadState.state must be atomic to avoid reported races.