gh-117657: Fix TSAN reported race in _PyEval_IsGILEnabled. - #119921
Merged
colesbury merged 1 commit intoJun 2, 2024
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
The GIL may be disabled concurrently with this call so we need to use a relaxed atomic load.
corona10
approved these changes
Jun 2, 2024
corona10
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
_PyEval_IsGILEnabled is called at free-threaded build only so using atomic operation directly looks reasonable.
LGTM
Sorry, something went wrong.
Copy link
Copy Markdown
|
Thanks @colesbury for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13. |
Sorry, something went wrong.
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jun 2, 2024
…ythonGH-119921) The GIL may be disabled concurrently with this call so we need to use a relaxed atomic load. (cherry picked from commit f3b89a6) Co-authored-by: Sam Gross <colesbury@gmail.com>
Copy link
Copy Markdown
|
GH-119939 is a backport of this pull request to the 3.13 branch. |
Sorry, something went wrong.
mliezun
pushed a commit
to mliezun/cpython
that referenced
this pull request
Jun 3, 2024
…ython#119921) The GIL may be disabled concurrently with this call so we need to use a relaxed atomic load.
barneygale
pushed a commit
to barneygale/cpython
that referenced
this pull request
Jun 5, 2024
…ython#119921) The GIL may be disabled concurrently with this call so we need to use a relaxed atomic load.
noahbkim
pushed a commit
to hudson-trading/cpython
that referenced
this pull request
Jul 11, 2024
…ython#119921) The GIL may be disabled concurrently with this call so we need to use a relaxed atomic load.
estyxx
pushed a commit
to estyxx/cpython
that referenced
this pull request
Jul 17, 2024
…ython#119921) The GIL may be disabled concurrently with this call so we need to use a relaxed atomic load.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The GIL may be disabled concurrently with this call so we need to use a relaxed atomic load.