FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-119826: `ntpath.abspath()` always return absolute path by nineteendo · Pull Request #119938 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

gh-119826: ntpath.abspath() always return absolute path - #119938

Merged
zooba merged 13 commits into
python:mainfrom
nineteendo:fix-ntpath.abspath-2
Nov 12, 2024
ConversationCommits (13)ChecksFiles changed
Merged

gh-119826: ntpath.abspath() always return absolute path#119938
zooba merged 13 commits into
python:mainfrom
nineteendo:fix-ntpath.abspath-2

Conversation

nineteendo commented Jun 2, 2024 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor

bedevere-app Bot mentioned this pull request Jun 2, 2024
Closed
nineteendo marked this pull request as ready for review June 2, 2024 11:54
eryksun reviewed Jun 2, 2024
View reviewed changes
Comment thread Lib/ntpath.py Outdated
eryksun reviewed Jun 2, 2024
View reviewed changes
Comment thread Lib/ntpath.py Outdated
nineteendo and others added 2 commits June 2, 2024 14:27
Update Lib/ntpath.py
4a26721 
Co-authored-by: Eryk Sun <eryksun@gmail.com>
Update Lib/ntpath.py
d2b45fe 
Co-authored-by: Eryk Sun <eryksun@gmail.com>
eryksun reviewed Jun 2, 2024
View reviewed changes
Comment thread Lib/ntpath.py
eryksun reviewed Jun 3, 2024
View reviewed changes
Comment thread Lib/ntpath.py Outdated
nineteendo and others added 3 commits June 3, 2024 08:34

nineteendo commented Oct 8, 2024

Copy link
Copy Markdown
Contributor Author

cc @zooba

zooba enabled auto-merge (squash) November 12, 2024 20:45

zooba commented Nov 12, 2024

Copy link
Copy Markdown
Member

Thanks for the contribution! Apologies for taking so long to get to it.

zooba merged commit 4b00aba into python:main Nov 12, 2024
nineteendo deleted the fix-ntpath.abspath-2 branch November 13, 2024 06:00

nineteendo commented Nov 13, 2024

Copy link
Copy Markdown
Contributor Author

Do we backport this?

erlend-aasland commented Nov 13, 2024

Copy link
Copy Markdown
Contributor

Do we backport this?

The issue is marked with type-feature; we do not backport features.

nineteendo commented Nov 13, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

The issue should probably be split up in 3:

  1. normpath('C:.'): bug for relative paths
  2. abspath('C:\x00'): always return absolute path
  3. abspath('./con'): support qualified referencing

The third counts as a feature, but I'm not sure about the first two.

zooba added the needs backport to 3.12 only security fixes label Dec 2, 2024
zooba added the needs backport to 3.13 only security fixes label Dec 2, 2024

miss-islington-app Bot commented Dec 2, 2024

Copy link
Copy Markdown

Thanks @nineteendo for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

miss-islington-app Bot commented Dec 2, 2024

Copy link
Copy Markdown

Thanks @nineteendo for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 2, 2024
pythongh-119826: Improved fallback for ntpath.abspath() on Windows (p…
c190efe 
…ythonGH-119938)

(cherry picked from commit 4b00aba)

Co-authored-by: Nice Zombies <nineteendo19d0@gmail.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 2, 2024
pythongh-119826: Improved fallback for ntpath.abspath() on Windows (p…
ff50ec2 
…ythonGH-119938)

(cherry picked from commit 4b00aba)

Co-authored-by: Nice Zombies <nineteendo19d0@gmail.com>

bedevere-app Bot commented Dec 2, 2024

Copy link
Copy Markdown

GH-127534 is a backport of this pull request to the 3.12 branch.

bedevere-app Bot removed the needs backport to 3.12 only security fixes label Dec 2, 2024

bedevere-app Bot commented Dec 2, 2024

Copy link
Copy Markdown

GH-127535 is a backport of this pull request to the 3.13 branch.

bedevere-app Bot removed the needs backport to 3.13 only security fixes label Dec 2, 2024

zooba commented Dec 2, 2024

Copy link
Copy Markdown
Member

This part of the change is only a bugfix, and only affects currently invalid results, so it's fine to backport. Other PRs attached to the same issue might be considered features (or at least too invasive to backport).

zooba pushed a commit that referenced this pull request Dec 2, 2024
gh-119826: Improved fallback for ntpath.abspath() on Windows (GH-119938)
af2d24b 
(cherry picked from commit 4b00aba)

Co-authored-by: Nice Zombies <nineteendo19d0@gmail.com>
zooba pushed a commit that referenced this pull request Dec 2, 2024
gh-119826: Improved fallback for ntpath.abspath() on Windows (GH-119938)
a853610 
(cherry picked from commit 4b00aba)

Co-authored-by: Nice Zombies <nineteendo19d0@gmail.com>
picnixz pushed a commit to picnixz/cpython that referenced this pull request Dec 8, 2024
pythongh-119826: Improved fallback for ntpath.abspath() on Windows (p…
c10dece 
…ythonGH-119938)
ebonnal pushed a commit to ebonnal/cpython that referenced this pull request Jan 12, 2025
pythongh-119826: Improved fallback for ntpath.abspath() on Windows (p…
6713633 
…ythonGH-119938)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

eryksun eryksun left review comments
erlend-aasland erlend-aasland left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL