FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Alternarive for bpo-29553 - Fixed ArgumentParses format_usage for mutually exclusive groups by andrewnester · Pull Request #120 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

Alternarive for bpo-29553 - Fixed ArgumentParses format_usage for mutually exclusive groups - #120

Closed
andrewnester wants to merge 4 commits into
python:masterfrom
andrewnester:29553-argument-parser-alternative
ConversationCommits (4)ChecksFiles changed
Closed

Alternarive for bpo-29553 - Fixed ArgumentParses format_usage for mutually exclusive groups#120
andrewnester wants to merge 4 commits into
python:masterfrom
andrewnester:29553-argument-parser-alternative

Conversation

andrewnester commented Feb 15, 2017

Copy link
Copy Markdown
Contributor

Fix for https://bugs.python.org/issue29553
Alternative to #117
This alternative advised by Christoph Stahl and Brian Curtin

andrewnester changed the title bpo-29553 - Fixed ArgumentParses format_usage for mutually exclusive groups Alternarive for bpo-29553 - Fixed ArgumentParses format_usage for mutually exclusive groups Feb 15, 2017
berkerpeksag requested changes Feb 19, 2017
View reviewed changes

berkerpeksag left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

See #117 (comment) about tests I left in #117.

andrewnester commented Feb 19, 2017

Copy link
Copy Markdown
Contributor Author

@berkerpeksag thanks! just updated my PR.

zhangyangyu reviewed Feb 22, 2017
View reviewed changes
Comment thread Misc/NEWS Outdated

zhangyangyu Feb 22, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

We need an empty line here.

andrewnester Feb 22, 2017

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

@zhangyangyu updated, sorry! thanks!

akruis pushed a commit to akruis/cpython that referenced this pull request Sep 9, 2017
merge 3.4-slp (Stackless python#120)
f568fd7
akruis pushed a commit to akruis/cpython that referenced this pull request Sep 9, 2017
Issue python#120: Correctly grab the head_mutex
66f017b 
Stackless now correctly grabs and releases the head_mutex, if it
iterates over the linked list of Py_ThreadState structures.

https://bitbucket.org/stackless-dev/stackless/issues/120
(grafted from 1fb75d58a98083b2547746adb21fa238bbf8135a)
akruis pushed a commit to akruis/cpython that referenced this pull request Sep 9, 2017
merge 3.3-slp (Stackless python#120)
b531101
akruis pushed a commit to akruis/cpython that referenced this pull request Sep 9, 2017
Issue python#120: Correctly grab the head_mutex, fix grafting error
ae1d0a4 
This commit fixes a regression introduced by commit fc13eecdd0ad.
When I grafted the patch for this issue from branch 2.7-slp (1fb75d58a), I forgot to remove a 2.7-slp only part of the code.
In effect, this change reapplies commit b8a8122bbb91.

https://bitbucket.org/stackless-dev/stackless/issues/120
akruis pushed a commit to akruis/cpython that referenced this pull request Sep 9, 2017
merge 3.3-slp (Stackless python#120, fix grafting error)
5b2c817
akruis pushed a commit to akruis/cpython that referenced this pull request Sep 9, 2017
merge 3.4-slp (Stackless python#120, fix grafting error)
f2db876

brettcannon commented Feb 21, 2018

Copy link
Copy Markdown
Member

To try and help move older pull requests forward, we are going through and backfilling 'awaiting' labels on pull requests that are lacking the label. Based on the current reviews, the best we can tell in an automated fashion is that a core developer requested changes to be made to this pull request.

If/when the requested changes have been made, please leave a comment that says, I have made the requested changes; please review again. That will trigger a bot to flag this pull request as ready for a follow-up review.

berkerpeksag commented Aug 31, 2019

Copy link
Copy Markdown
Member

Superseded by PR #14976.

jaraco pushed a commit that referenced this pull request Dec 2, 2022
Update requests-mock from 1.5.0 to 1.5.2 (#120)
2ccb5e2
gvanrossum mentioned this pull request Aug 22, 2023
Closed
This was referenced Feb 11, 2025
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

zhangyangyu zhangyangyu left review comments
berkerpeksag berkerpeksag requested changes

Assignees

No one assigned

Labels

awaiting changes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL