gh-120029: export DEF_TYPE_PARAM compiler flag - #120028
Merged
JelleZijlstra merged 5 commits intoJun 4, 2024
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
JelleZijlstra
self-requested a review
June 4, 2024 14:01
JelleZijlstra
approved these changes
Jun 4, 2024
Copy link
Copy Markdown
Member
Author
|
@JelleZijlstra By the way, should this PR be backported to 3.12 and 3.13? |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
I don't think so, we're adding a method so this is a new feature. |
Sorry, something went wrong.
barneygale
pushed a commit
to barneygale/cpython
that referenced
this pull request
Jun 5, 2024
noahbkim
pushed a commit
to hudson-trading/cpython
that referenced
this pull request
Jul 11, 2024
estyxx
pushed a commit
to estyxx/cpython
that referenced
this pull request
Jul 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR, I decided to only export the DEF_TYPE_PARAM flag for now. Note that some flags are exported but not exposed in repr() but I will not change that behaviour for now. Other flags such as DEF_COMP_ITER could be exported and used but I decided not to do it for now as well.
I changed some stylistic parts as well since they were probably missed. Note that the order of the imports in symtable affect the repr() (maybe it would have been preferrable to change the macros' values...).