gh-120029: refactor symtable.c (remove deprecated macros and update some values) - #120218
Closed
picnixz wants to merge 3 commits into
Closed
gh-120029: refactor symtable.c (remove deprecated macros and update some values)#120218picnixz wants to merge 3 commits into
picnixz wants to merge 3 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
- remove unused flag `DEF_FREE` - remove unused macros `GENERATOR` and `GENERATOR_EXPRESSION` - update values of `DEF_*` and `USE` flags - reflect new ordering in the code
picnixz
requested review from
JelleZijlstra,
brettcannon,
carljm,
ericsnowcurrently,
ncoghlan and
warsaw
as code owners
June 7, 2024 11:12
picnixz
marked this pull request as draft
June 7, 2024 11:30
Copy link
Copy Markdown
Member
Author
|
Converting into a draft to split the PR into two (so that we can discuss whether the re-ordering and the value's changes should be done or not). I'll open a separate PR for that. |
Sorry, something went wrong.
brettcannon
removed their request for review
June 11, 2024 20:35
Copy link
Copy Markdown
Member
Author
|
In light of Jelle's comment (#120029 (comment)), I will not change any concrete values here. Maybe in the future we will update them to reflect their usage in symtable.py, but let's keep it that way for now. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes DEF_FREE and the unused GENERATOR and GENERATOR_EXPRESSION macros.
In addition, I re-ordered the values of the flags so that they are meaningfully separated (and made that reflection on the export order and the debug order). Note that some comments were outdated (and I updated them accordingly).
I will address the import order of symtable in a separate PR and make it so that the flags are meaningfully printed.
By the way, I'm not sure if this change really required updating the magic number (compile.c checks flags so if the numbers change, then an old bytecode might perhaps have incorrect flag values, (unless they are not kept)).