[3.12] gh-71587: Drop local reference cache to _strptime module in _datetime (GH-120224) - #120431
Merged
ericsnowcurrently merged 3 commits intoJun 13, 2024
Merged
[3.12] gh-71587: Drop local reference cache to _strptime module in _datetime (GH-120224)#120431ericsnowcurrently merged 3 commits into
ericsnowcurrently merged 3 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
Test not included, as the test_embed case requires the following changes:
|
Sorry, something went wrong.
auto-merge was automatically disabled
June 12, 2024 20:23
Head branch was pushed to by a user without write access
Copy link
Copy Markdown
Contributor
Author
|
This now avoids ABI changes. I'm not sure #118618 (comment) can be applied here. I'm fine with this. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The _strptime module object was cached in a static local variable (in the datetime.strptime() implementation). That's a problem when it crosses isolation boundaries, such as reinitializing the runtme or between interpreters. This change fixes the problem by dropping the static variable, instead always relying on the normal sys.modules cache (via PyImport_Import()).
(cherry picked from commit 127c1d2, AKA gh-120224)