gh-117657: Fix data races for set_inheritable in fileutils.c with free-threaded builds - #120458
Closed
aisk wants to merge 1 commit into
Closed
gh-117657: Fix data races for set_inheritable in fileutils.c with free-threaded builds#120458aisk wants to merge 1 commit into
aisk wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
Sorry, just noticed that this is duplicated with #120175. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ioctl_works in set_inheritable function is a static variable which has three possible values:
When it is 0, using ioctl as a fast path will always be skipped.
When it is -1 or 1, ioctl will be used as a fast path to perform the functionality, and it will be set to 0 or 1 based on the result of whether ioctl raises an error or not. And if ioctl failed, use fnctl as a slow path fallback.
Following this logic, it is safe to call set_inheritable with multiple threads in a free-threaded build. The fast path can be safely used even if it leads to failure. Therefore, we can simply use atomic operations to read or write ioctl_works's value to resolve data races.