FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[3.12] gh-119897: Revert buggy optimization which was removed in 3.13 by iritkatriel · Pull Request #120467 · python/cpython · GitHub

/ cpython Public

[3.12] gh-119897: Revert buggy optimization which was removed in 3.13 - #120467

Merged
iritkatriel merged 3 commits into
python:3.12from
iritkatriel:gh-119897
Jun 18, 2024
ConversationCommits (3)ChecksFiles changed
Merged

[3.12] gh-119897: Revert buggy optimization which was removed in 3.13#120467
iritkatriel merged 3 commits into
python:3.12from
iritkatriel:gh-119897

Conversation

iritkatriel commented Jun 13, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

iritkatriel requested a review from markshannon as a code owner June 13, 2024 18:26
bedevere-app Bot mentioned this pull request Jun 13, 2024
Closed

mgorny commented Jun 15, 2024

Copy link
Copy Markdown
Contributor

Thanks for doing this!

markshannon commented Jun 17, 2024

Copy link
Copy Markdown
Member

Is it worth adding a test for issue described in #119897?

markshannon commented Jun 17, 2024

Copy link
Copy Markdown
Member

Does this need a news item?

iritkatriel commented Jun 17, 2024

Copy link
Copy Markdown
Member Author

Is it worth adding a test for issue described in #119897?

I'll add that in a separate PR to main.

iritkatriel commented Jun 17, 2024

Copy link
Copy Markdown
Member Author

Does this need a news item?

No, none of this stuff was in the news.

iritkatriel commented Jun 17, 2024

Copy link
Copy Markdown
Member Author

Is it worth adding a test for issue described in #119897?

I'll add that in a separate PR to main.

Actually I'll add it here and then another PR for main and 3.13.

iritkatriel added a commit to iritkatriel/cpython that referenced this pull request Jun 17, 2024
pythongh-120467: Add test for lambda generator invocation
2d525d4
iritkatriel added a commit that referenced this pull request Jun 18, 2024
gh-119897: Add test for lambda generator invocation (#120658)
73dc1c6 
gh-120467: Add test for lambda generator invocation
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 18, 2024
pythongh-119897: Add test for lambda generator invocation (pythonGH-1…
88395b5 
…20658)

(cherry picked from commit 73dc1c6)

Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>
pythongh-120467: Add test for lambda generator invocation
miss-islington mentioned this pull request Jun 18, 2024
Merged
iritkatriel merged commit 5d997b5 into python:3.12 Jun 18, 2024
iritkatriel added a commit that referenced this pull request Jun 18, 2024
[3.13] gh-119897: Add test for lambda generator invocation (GH-120658) (
692874c 
#120673)

gh-119897: Add test for lambda generator invocation (GH-120658)
(cherry picked from commit 73dc1c6)


gh-120467: Add test for lambda generator invocation

Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>
eevelweezel mentioned this pull request Jun 20, 2024
Closed
mrahtz pushed a commit to mrahtz/cpython that referenced this pull request Jun 30, 2024
pythongh-119897: Add test for lambda generator invocation (python#120658
bed6d9c 
)

pythongh-120467: Add test for lambda generator invocation
noahbkim pushed a commit to hudson-trading/cpython that referenced this pull request Jul 11, 2024
pythongh-119897: Add test for lambda generator invocation (python#120658
7ea3b1e 
)

pythongh-120467: Add test for lambda generator invocation
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
pythongh-119897: Add test for lambda generator invocation (python#120658
c70aa2b 
)

pythongh-120467: Add test for lambda generator invocation
jacobtylerwalls mentioned this pull request Aug 17, 2024
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

markshannon markshannon approved these changes

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL