FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Fix typos in comments by xyb · Pull Request #120481 · python/cpython · GitHub

/ cpython Public

Fix typos in comments - #120481

Merged
terryjreedy merged 1 commit into
python:mainfrom
xyb:fixtypos
Jun 20, 2024
ConversationCommits (1)ChecksFiles changed
Merged

Fix typos in comments#120481
terryjreedy merged 1 commit into
python:mainfrom
xyb:fixtypos

Conversation

xyb commented Jun 14, 2024

Copy link
Copy Markdown
Contributor

No description provided.

Wulian233 commented Jun 14, 2024

Copy link
Copy Markdown
Contributor

LGTM

xyb commented Jun 20, 2024

Copy link
Copy Markdown
Contributor Author

@sobolevn @terryjreedy Could you please take a look?

terryjreedy merged commit 656a1c8 into python:main Jun 20, 2024

miss-islington-app Bot commented Jun 20, 2024

Copy link
Copy Markdown

Thanks @xyb for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 20, 2024
Fix typos in comments (pythonGH-120481)
f5ad386 
(cherry picked from commit 656a1c8)

Co-authored-by: Xie Yanbo <xieyanbo@gmail.com>

miss-islington-app Bot commented Jun 20, 2024

Copy link
Copy Markdown

Sorry, @xyb and @terryjreedy, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 656a1c81083b76b9d998c983f4329348a65985d3 3.12

bedevere-app Bot commented Jun 20, 2024

Copy link
Copy Markdown

GH-120774 is a backport of this pull request to the 3.13 branch.

bedevere-app Bot removed the needs backport to 3.13 bugs and security fixes label Jun 20, 2024
terryjreedy pushed a commit that referenced this pull request Jun 20, 2024
[3.13] Fix typos in comments (GH-120481) (#120774)
5d19490 
(cherry picked from commit 656a1c8)

Co-authored-by: Xie Yanbo <xieyanbo@gmail.com>
terryjreedy added a commit to terryjreedy/cpython that referenced this pull request Jun 20, 2024
[3.12] Fix typos in comments (pythonGH-120481)
f13f822 
(cherry picked from commit 656a1c8)

Co-authored-by: Xie Yanbo xieyanbo@gmail.com

bedevere-app Bot commented Jun 20, 2024

Copy link
Copy Markdown

GH-120775 is a backport of this pull request to the 3.12 branch.

bedevere-app Bot removed the needs backport to 3.12 only security fixes label Jun 20, 2024

terryjreedy commented Jun 20, 2024

Copy link
Copy Markdown
Member

Thanks. I backported the one applicable change to 3.12.

terryjreedy added a commit that referenced this pull request Jun 20, 2024
[3.12] Fix typos in comments (GH-120481) (#120775)
61e37dd 
Only 1 applicable change backported to 3.12.

(cherry picked from commit 656a1c8)

Co-authored-by: Xie Yanbo xieyanbo@gmail.com
python deleted a comment from bedevere-bot Jun 20, 2024

terryjreedy commented Jun 20, 2024

Copy link
Copy Markdown
Member

Deleted test_socketserver failure on buildbot.

xyb deleted the fixtypos branch June 21, 2024 08:11

xyb commented Jun 21, 2024

Copy link
Copy Markdown
Contributor Author

@terryjreedy Thank you!

mrahtz pushed a commit to mrahtz/cpython that referenced this pull request Jun 30, 2024
Fix typos in comments (python#120481)
5648bdf
noahbkim pushed a commit to hudson-trading/cpython that referenced this pull request Jul 11, 2024
Fix typos in comments (python#120481)
353d90d
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
Fix typos in comments (python#120481)
ec0f7d6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

terryjreedy

Labels

skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL