gh-117657: Using critical section to make _socket.socket.close thread safe - #120490
Merged
encukou merged 1 commit intoJul 1, 2024
Merged
gh-117657: Using critical section to make _socket.socket.close thread safe#120490encukou merged 1 commit into
encukou merged 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Fidget-Spinner
approved these changes
Jun 14, 2024
Copy link
Copy Markdown
Member
|
Will wait some time for someone else to give a review if they want to. |
Sorry, something went wrong.
kumaraditya303
approved these changes
Jun 19, 2024
encukou
approved these changes
Jul 1, 2024
encukou
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
It looks straightforward to me :)
Sorry, something went wrong.
Akasurde
pushed a commit
to Akasurde/cpython
that referenced
this pull request
Jul 3, 2024
noahbkim
pushed a commit
to hudson-trading/cpython
that referenced
this pull request
Jul 11, 2024
estyxx
pushed a commit
to estyxx/cpython
that referenced
this pull request
Jul 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This function has a temporary variable fd which will be fetched and stored from or to _socket.socket.fd, so using critical section to make it thread safe with free-threads build.