FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-117657: Add TSAN suppression for set_default_allocator_unlocked by aisk · Pull Request #120500 · python/cpython · GitHub

/ cpython Public

gh-117657: Add TSAN suppression for set_default_allocator_unlocked - #120500

Merged
Fidget-Spinner merged 1 commit into
python:mainfrom
aisk:update-tsan-suppression
Jun 14, 2024
ConversationCommits (1)ChecksFiles changed
Merged

gh-117657: Add TSAN suppression for set_default_allocator_unlocked#120500
Fidget-Spinner merged 1 commit into
python:mainfrom
aisk:update-tsan-suppression

Conversation

aisk commented Jun 14, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

I'm using macOS 14.2 with x86_64 CPU, this race conflict always occurs on my local machine.

Clang version:

clang -v
Apple clang version 15.0.0 (clang-1500.3.9.4)
Target: x86_64-apple-darwin23.2.0
Thread model: posix
InstalledDir: /Library/Developer/CommandLineTools/usr/bin

bedevere-app Bot mentioned this pull request Jun 14, 2024
Closed
aisk added skip news needs backport to 3.13 bugs and security fixes labels Jun 14, 2024
Fidget-Spinner approved these changes Jun 14, 2024
View reviewed changes

Fidget-Spinner left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

There's quite a few socket races as well that pop up. We should add them to the suppressions.

aisk commented Jun 14, 2024

Copy link
Copy Markdown
Member Author

I think we can enable the TSAN free-threads builds tests on macOS?

aisk commented Jun 14, 2024 •
edited
Loading

Copy link
Copy Markdown
Member Author

Tried to enable TSAN check on macOS #120502, but it will hang forever for the test_capi.test_mem test, and the set_default_allocator_unlocked race didn't get triggered...

https://github.com/python/cpython/actions/runs/9517250225/job/26235426291?pr=120502

Updated:

Sorry, my bad, the set_default_allocator_unlocked race did get triggered, but the races on socket didn't triggered. So I think we can continue with this change, and I will find a way to resolve the hang in another PR.

Fidget-Spinner merged commit 2bacc23 into python:main Jun 14, 2024

miss-islington-app Bot commented Jun 14, 2024

Copy link
Copy Markdown

Thanks @aisk for the PR, and @Fidget-Spinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 14, 2024
pythongh-117657: Add TSAN suppression for set_default_allocator_unloc…
4df21bd 
…ked (pythonGH-120500)

Add TSAN suppression for set_default_allocator_unlocked
(cherry picked from commit 2bacc23)

Co-authored-by: AN Long <aisk@users.noreply.github.com>

bedevere-app Bot commented Jun 14, 2024

Copy link
Copy Markdown

GH-120510 is a backport of this pull request to the 3.13 branch.

bedevere-app Bot removed the needs backport to 3.13 bugs and security fixes label Jun 14, 2024
Fidget-Spinner pushed a commit that referenced this pull request Jun 14, 2024
[3.13] gh-117657: Add TSAN suppression for set_default_allocator_unlo…
6e3e112 
…cked (GH-120500) (#120510)

gh-117657: Add TSAN suppression for set_default_allocator_unlocked (GH-120500)

Add TSAN suppression for set_default_allocator_unlocked
(cherry picked from commit 2bacc23)

Co-authored-by: AN Long <aisk@users.noreply.github.com>
aisk deleted the update-tsan-suppression branch June 14, 2024 16:48
aisk mentioned this pull request Jun 18, 2024
Open
mrahtz pushed a commit to mrahtz/cpython that referenced this pull request Jun 30, 2024
pythongh-117657: Add TSAN suppression for set_default_allocator_unloc…
338496d 
…ked (python#120500)

Add TSAN suppression for set_default_allocator_unlocked
noahbkim pushed a commit to hudson-trading/cpython that referenced this pull request Jul 11, 2024
pythongh-117657: Add TSAN suppression for set_default_allocator_unloc…
3339708 
…ked (python#120500)

Add TSAN suppression for set_default_allocator_unlocked
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
pythongh-117657: Add TSAN suppression for set_default_allocator_unloc…
924104a 
…ked (python#120500)

Add TSAN suppression for set_default_allocator_unlocked
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Fidget-Spinner Fidget-Spinner approved these changes

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL