FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-120560: Mark `zip64` tests in `test_zipimport` as cpu-heavy by nineteendo · Pull Request #120564 · python/cpython · GitHub

/ cpython Public

gh-120560: Mark zip64 tests in test_zipimport as cpu-heavy - #120564

Merged
brettcannon merged 1 commit into
python:mainfrom
nineteendo:testZip64-require-cpu
Jun 17, 2024
ConversationCommits (1)ChecksFiles changed
Merged

gh-120560: Mark zip64 tests in test_zipimport as cpu-heavy#120564
brettcannon merged 1 commit into
python:mainfrom
nineteendo:testZip64-require-cpu

Conversation

nineteendo commented Jun 15, 2024 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor

bedevere-app Bot mentioned this pull request Jun 15, 2024
Closed
bedevere-app Bot added the tests Tests in the Lib/test dir label Jun 15, 2024
nineteendo marked this pull request as ready for review June 15, 2024 18:50

ncoghlan commented Jun 16, 2024

Copy link
Copy Markdown
Contributor

I think bedevere is right on this one: there should be a NEWS entry in the test section noting that running these tests now requires the cpu resource.

The change itself looks fine, though.

nineteendo commented Jun 16, 2024

Copy link
Copy Markdown
Contributor Author

From the devguide:

Most changes made to the codebase deserve an entry in Misc/NEWS.d, except for the following:

  • test changes

Eclips4 commented Jun 16, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

I think bedevere is right on this one: there should be a NEWS entry in the test section noting that running these tests now requires the cpu resource.

The change itself looks fine, though.

Previously when we were doing the same thing, we didn't write a NEWS entry, for example: #118801.
But if you want a NEWS entry, I wouldn't argue 🙂. We could write something like Due to high CPU utilization, zip64 tests in test_zipimport were marked as a cpu-heavy tests.

brettcannon merged commit ac37a80 into python:main Jun 17, 2024

brettcannon commented Jun 17, 2024

Copy link
Copy Markdown
Member

Thanks!

nineteendo deleted the testZip64-require-cpu branch June 18, 2024 04:58
mrahtz pushed a commit to mrahtz/cpython that referenced this pull request Jun 30, 2024
pythongh-120560: Mark zip64 tests in test_zipimport as CPU-heavy (p…
9267431 
…ythonGH-120564)
noahbkim pushed a commit to hudson-trading/cpython that referenced this pull request Jul 11, 2024
pythongh-120560: Mark zip64 tests in test_zipimport as CPU-heavy (p…
e67e31c 
…ythonGH-120564)
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
pythongh-120560: Mark zip64 tests in test_zipimport as CPU-heavy (p…
9674a53 
…ythonGH-120564)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

brettcannon brettcannon approved these changes
ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner
ncoghlan Awaiting requested review from ncoghlan ncoghlan is a code owner
warsaw Awaiting requested review from warsaw warsaw is a code owner

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL