gh-120568: fix file leak in PyUnstable_CopyPerfMapFile - #120569
Merged
kumaraditya303 merged 3 commits intoJun 16, 2024
Merged
kumaraditya303 merged 3 commits into
kumaraditya303 merged 3 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
sobolevn
reviewed
Jun 16, 2024
Comment thread
Python/sysmodule.c
Comment thread
Python/sysmodule.c
carsonRadtke
force-pushed
the
fix-file-leak
branch
from
ec1d48d to
b1e5b8f
Compare
June 16, 2024 15:17
kumaraditya303
approved these changes
Jun 16, 2024
Copy link
Copy Markdown
⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️Hi! The buildbot AMD64 Windows11 Bigmem 3.x has failed when building commit 92cebaa. What do you need to do:
You can take a look at the buildbot page here: https://buildbot.python.org/all/#builders/1079/builds/4239 Failed tests:
Failed subtests:
Summary of the results of the build (if available): == Click to see traceback logsTraceback (most recent call last):
File "R:\buildarea\3.x.ambv-bb-win11.bigmem\build\Lib\test\test_repl.py", line 199, in test_asyncio_repl_is_ok
assert_python_ok("-m", "asyncio")
~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^
File "R:\buildarea\3.x.ambv-bb-win11.bigmem\build\Lib\test\support\script_helper.py", line 180, in assert_python_ok
return _assert_python(True, *args, **env_vars)
File "R:\buildarea\3.x.ambv-bb-win11.bigmem\build\Lib\test\support\script_helper.py", line 165, in _assert_python
res.fail(cmd_line)
~~~~~~~~^^^^^^^^^^
File "R:\buildarea\3.x.ambv-bb-win11.bigmem\build\Lib\test\support\script_helper.py", line 75, in fail
raise AssertionError("Process return code is %d\n"
...<13 lines>...
err))
AssertionError: Process return code is 2147483651
command line: ['R:\\buildarea\\3.x.ambv-bb-win11.bigmem\\build\\PCbuild\\amd64\\python_d.exe', '-X', 'faulthandler', '-I', '-m', 'asyncio']
|
Sorry, something went wrong.
mrahtz
pushed a commit
to mrahtz/cpython
that referenced
this pull request
Jun 30, 2024
noahbkim
pushed a commit
to hudson-trading/cpython
that referenced
this pull request
Jul 11, 2024
estyxx
pushed a commit
to estyxx/cpython
that referenced
this pull request
Jul 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a file leak in PyUnstable_CopyPerfMapFile found by the Clang Static Analyzer.