FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-117953: Skip `test_interpreters` properly without GIL by nineteendo · Pull Request #120689 · python/cpython · GitHub

/ cpython Public

gh-117953: Skip test_interpreters properly without GIL - #120689

Merged
vstinner merged 1 commit into
python:mainfrom
nineteendo:skip-test_interpreters-without-gil
Jun 18, 2024
ConversationCommits (1)ChecksFiles changed
Merged

gh-117953: Skip test_interpreters properly without GIL#120689
vstinner merged 1 commit into
python:mainfrom
nineteendo:skip-test_interpreters-without-gil

Conversation

nineteendo commented Jun 18, 2024 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor 
0:00:33 load avg: 2.57 [ 61/478] test_interpreters ran no tests -- running (1): test_subprocess (31.8 sec)
----------------------------------------------------------------------
Ran 0 tests in 0.000s

NO TESTS RAN

bedevere-app Bot mentioned this pull request Jun 18, 2024
Closed

nineteendo commented Jun 18, 2024

Copy link
Copy Markdown
Contributor Author

cc @vstinner

vstinner commented Jun 18, 2024

Copy link
Copy Markdown
Member

Can you please elaborate?

nineteendo commented Jun 18, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Same issue as here: #120660 (comment). test_interpreters isn't skipped properly:

1 test run no tests:
    test_interpreters

This is distracting when reading through the logs and the same change you asked me to make (mine didn't even work).

ericsnowcurrently approved these changes Jun 18, 2024
View reviewed changes

ericsnowcurrently left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

FWIW, the skipping should be removed in the near future. (See #117953 (comment).) However, fixing this in the meantime makes sense.

vstinner enabled auto-merge (squash) June 18, 2024 15:07

vstinner commented Jun 18, 2024

Copy link
Copy Markdown
Member

Should the change be backported to the 3.13 branch?

This comment was marked as outdated.

Sign in to view
vstinner merged commit 1035fe0 into python:main Jun 18, 2024

vstinner commented Jun 18, 2024

Copy link
Copy Markdown
Member

Merged, thanks.

nineteendo deleted the skip-test_interpreters-without-gil branch June 18, 2024 15:30

ericsnowcurrently commented Jun 18, 2024

Copy link
Copy Markdown
Member

gh-118157 was merged before the feature freeze, thus it is part of the 3.13 branch. Backporting this would make sense.

ericsnowcurrently added the needs backport to 3.13 bugs and security fixes label Jun 18, 2024

miss-islington-app Bot commented Jun 18, 2024

Copy link
Copy Markdown

Thanks @nineteendo for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 18, 2024
pythongh-117953: Skip test_interpreters properly without GIL (pytho…
37e8945 
…nGH-120689)

(cherry picked from commit 1035fe0)

Co-authored-by: Nice Zombies <nineteendo19d0@gmail.com>

bedevere-app Bot commented Jun 18, 2024

Copy link
Copy Markdown

GH-120707 is a backport of this pull request to the 3.13 branch.

bedevere-app Bot removed the needs backport to 3.13 bugs and security fixes label Jun 18, 2024

nineteendo commented Jun 18, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Hmm, should we include the version in the title of all pull requests? [3.14] gh-117953: Skip `test_interpreters` properly without GIL. That would make it easier to determine in which version something was added.

ericsnowcurrently pushed a commit that referenced this pull request Jun 18, 2024
[3.13] gh-117953: Skip test_interpreters properly without GIL (gh-1…
07145dd 
…20707)

(cherry picked from commit 1035fe0, AKA gh-120689)

Co-authored-by: Nice Zombies <nineteendo19d0@gmail.com>

ericsnowcurrently commented Jun 18, 2024

Copy link
Copy Markdown
Member

I'm not sure it would be worth it. The time interval in which there's any uncertainty is relatively small and the target version for a PR against main can shift depending on how long its open. It isn't too hard to see if a commit (from a PR) is included in a specific release branch (or tag).

nineteendo commented Jun 18, 2024

Copy link
Copy Markdown
Contributor Author

OK, probably not worth it. I just feel bad for making a mistake because of it.

ericsnowcurrently commented Jun 18, 2024

Copy link
Copy Markdown
Member

There's nothing to feel bad about! We figured it out pretty quickly and even if we hadn't, it wouldn't have been a big deal.

picnixz pushed a commit to picnixz/cpython that referenced this pull request Jun 19, 2024
pythongh-117953: Skip test_interpreters properly without GIL (pytho…
145a126 
…n#120689)
mrahtz pushed a commit to mrahtz/cpython that referenced this pull request Jun 30, 2024
pythongh-117953: Skip test_interpreters properly without GIL (pytho…
e5e61ea 
…n#120689)
noahbkim pushed a commit to hudson-trading/cpython that referenced this pull request Jul 11, 2024
pythongh-117953: Skip test_interpreters properly without GIL (pytho…
064368c 
…n#120689)
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
pythongh-117953: Skip test_interpreters properly without GIL (pytho…
69c6157 
…n#120689)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

ericsnowcurrently ericsnowcurrently approved these changes

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL