FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-120762: fix make_ssl_certs.py - no SKID or AKID in CSR by AdamWill · Pull Request #120764 · python/cpython · GitHub

/ cpython Public

gh-120762: fix make_ssl_certs.py - no SKID or AKID in CSR #120764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
AdamWill wants to merge 1 commit into from
+5 −1
Conversation 2 Commits 1 Checks 0 Files changed 1
Closed

gh-120762: fix make_ssl_certs.py - no SKID or AKID in CSR #120764

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension .py  (1) All 1 file type selected
Viewed files
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Unified
Split
Hide whitespace
Diff view
Unified
Split
Hide whitespace
6 changes: 5 additions & 1 deletion Lib/test/certdata/make_ssl_certs.py
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -125,6 +125,10 @@ def make_cert_key(hostname, sign=False, extra_san='',
with tempfile.NamedTemporaryFile(delete=False) as f:
tempnames.append(f.name)
req_file, cert_file, key_file = tempnames
if sign:
reqext = 'req_x509_extensions_simple'
else:
reqext = ext
try:
req = req_template.format(
hostname=hostname,
Expand All @@ -136,7 +140,7 @@ def make_cert_key(hostname, sign=False, extra_san='',
f.write(req)
args = ['req', '-new', '-nodes', '-days', '7000',
'-newkey', key, '-keyout', key_file,
'-extensions', ext,
'-extensions', reqext,
'-config', req_file]
if sign:
with tempfile.NamedTemporaryFile(delete=False) as f:
Expand Down
Back | FazBrowse Home | New Git URL