Revert "gh-120057: Add os.environ.refresh() method (#120059)" - #120790
Closed
vstinner wants to merge 1 commit into
Closed
Revert "gh-120057: Add os.environ.refresh() method (#120059)"#120790vstinner wants to merge 1 commit into
vstinner wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
…)" This reverts commit 7aff2de. The function is controversial and it was decided to remove it.
Copy link
Copy Markdown
Contributor
|
The discussion on the discourse thread hasn't concluded: a better name might make it more intuitive. |
Sorry, something went wrong.
vstinner
marked this pull request as draft
June 20, 2024 19:13
Copy link
Copy Markdown
Member
Author
|
According to https://discuss.python.org/t/method-to-refresh-os-environ/54774/101 poll, the majority prefers to keep the method and prefers the name refresh() for the method. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 7aff2de.
The function is controversial and it was decided to remove it.
📚 Documentation preview 📚: https://cpython-previews--120790.org.readthedocs.build/