FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-118507: Amend news entry by nineteendo · Pull Request #120817 · python/cpython · GitHub

/ cpython Public

gh-118507: Amend news entry - #120817

Merged
zooba merged 2 commits into
python:mainfrom
nineteendo:amend-news-entry
Jul 4, 2024
ConversationCommits (2)ChecksFiles changed
Merged

gh-118507: Amend news entry#120817
zooba merged 2 commits into
python:mainfrom
nineteendo:amend-news-entry

Conversation

nineteendo commented Jun 21, 2024 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor

Adds extra information only present in the backport to the 3.12 branch.

bedevere-app Bot added the docs Documentation in the Doc dir label Jun 21, 2024
bedevere-app Bot mentioned this pull request Jun 21, 2024
Closed

nineteendo commented Jul 4, 2024

Copy link
Copy Markdown
Contributor Author

cc @zooba

zooba commented Jul 4, 2024

Copy link
Copy Markdown
Member

I'm unclear. This PR is against main, which means we'll be announcing that pipes were fixed in 3.14 - why do you say it is only in 3.12?

Which branches need this change?

nineteendo commented Jul 4, 2024

Copy link
Copy Markdown
Contributor Author

That's correct, pipes were fixed in 3.13 and 3.14, but only the speedup to os.path.isjunction() and os.path.lexists() was mentioned. I only mentioned this fix in the backport to 3.12.

zooba added the needs backport to 3.13 bugs and security fixes label Jul 4, 2024
zooba merged commit db17291 into python:main Jul 4, 2024

miss-islington-app Bot commented Jul 4, 2024

Copy link
Copy Markdown

Thanks @nineteendo for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington-app Bot commented Jul 4, 2024

Copy link
Copy Markdown

Sorry, @nineteendo and @zooba, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker db1729143de0775c99e0453cb0fc01a799f289a0 3.13

nineteendo deleted the amend-news-entry branch July 4, 2024 14:58

bedevere-app Bot commented Jul 4, 2024

Copy link
Copy Markdown

GH-121365 is a backport of this pull request to the 3.13 branch.

bedevere-app Bot removed the needs backport to 3.13 bugs and security fixes label Jul 4, 2024
zooba added a commit that referenced this pull request Jul 4, 2024
gh-118507: Amend news entry to mention ntpath.isfile bugfix (GH-120817)
868e9ab
noahbkim pushed a commit to hudson-trading/cpython that referenced this pull request Jul 11, 2024
pythongh-118507: Amend news entry to mention ntpath.isfile bugfix (py…
ad6a172 
…thonGH-120817)
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
pythongh-118507: Amend news entry to mention ntpath.isfile bugfix (py…
1aa1017 
…thonGH-120817)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

zooba

Labels

docs Documentation in the Doc dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL