gh-120782: Update internal type cache when reloading datetime by neonene · Pull Request #120829 · python/cpython · GitHub

When reloading _datetime module, the single-phase version did not invoke the PyInit__datetime function, whereas the current multi-phase version updates the static types through the module init. The outdated static type cache in the interpreter state needs to be invalidated at the end of reloading the multi-phase module.

Issue: test_datetime fails with a --forever argument #120782

cc @ericsnowcurrently @Eclips4

LGTM

Thanks!

Should this have assert?

    assert isinstance(_datetime.timezone.min, _datetime.tzinfo)
           ~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError

    assert not isinstance(_datetime.timezone.min, _datetime.tzinfo)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError

Both fail, so this checks if it crashes or not. I agree this is not a good example.

Given that the code looks a bit unusual, it would be worth adding a brief comment explaining that.

(Sorry I didn't notice this during my earlier review. Good catch, @JelleZijlstra.)

Wouldn't it make sense to have these asserts actually check that the values are of the type they should be? The bug manifested itself as these values appearing to be objects of various random types.

You could also assert that timezone.__dict__["min"] is timezone.min.

Thanks. I'll make a backport PR to 3.13 manually with an assertion to the test case.

GH-120855 is a backport of this pull request to the 3.13 branch.

…ython#120829)

…H-120829) (#120855) * [3.13] gh-120782: Update internal type cache when reloading datetime When reloading _datetime module, the single-phase version did not invoke the PyInit__datetime function, whereas the current multi-phase version updates the static types through the module init. The outdated static type cache in the interpreter state needs to be invalidated at the end of reloading the multi-phase module.

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot iOS ARM64 Simulator 3.13 has failed when building commit 2c3aa52.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/1386/builds/305) and take a look at the build logs.
Check if the failure is related to this commit (2c3aa52) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/1386/builds/305

Failed tests:

test_datetime

Failed subtests:

test_type_check_in_subinterp - test.datetimetester.CapiTest_Fast.test_type_check_in_subinterp

Summary of the results of the build (if available):

==

Click to see traceback logs

Traceback (most recent call last):
  File �[35m"<string>"�[0m, line �[35m12�[0m, in �[35m<module>�[0m
  File �[35m"<frozen importlib._bootstrap>"�[0m, line �[35m813�[0m, in �[35mmodule_from_spec�[0m
  File �[35m"<frozen importlib._bootstrap_external>"�[0m, line �[35m1316�[0m, in �[35mcreate_module�[0m
  File �[35m"<frozen importlib._bootstrap>"�[0m, line �[35m488�[0m, in �[35m_call_with_frames_removed�[0m
�[1;35mImportError�[0m: �[35mdlopen(/Users/buildbot/Library/Developer/XCTestDevices/22CEEEC0-69AF-41A1-B570-E2195120FCE2/data/Containers/Bundle/Application/781AEFA7-0473-4CB0-82EE-01996600BD3C/iOSTestbed.app/python/lib/python3.13/lib-dynload/_testcapi.cpython-313d-iphonesimulator.fwork, 0x0002): tried: '/Users/buildbot/buildarea/3.13.rkm-arm64-ios-simulator.iOS-simulator.arm64/build/build_oot/host/iOSTestbed.arm64-iphonesimulator.1719996652/DerivedData/Build/Products/Debug-iphonesimulator/_testcapi.cpython-313d-iphonesimulator.fwork' (no such file), '/Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/usr/lib/_testcapi.cpython-313d-iphonesimulator.fwork' (no such file), '/Library/Developer/CoreSimulator/Volumes/iOS_21F79/Library/Developer/CoreSimulator/Profiles/Runtimes/iOS 17.5.simruntime/Contents/Resources/RuntimeRoot/Users/buildbot/Library/Developer/XCTestDevices/22CEEEC0-69AF-41A1-B570-E2195120FCE2/data/Containers/Bundle/Application/781AEFA7-0473-4CB0-82EE-01996600BD3C/iOSTestbed.app/python/lib/python3.13/lib-dynload/_testcapi.cpython-313d-iphonesimulator.fwork' (no such file), '/Users/buildbot/Library/Developer/XCTestDevices/22CEEEC0-69AF-41A1-B570-E2195120FCE2/data/Containers/Bundle/Application/781AEFA7-0473-4CB0-82EE-01996600BD3C/iOSTestbed.app/python/lib/python3.13/lib-dynload/_testcapi.cpython-313d-iphonesimulator.fwork' (not a mach-o file)�[0m
Traceback (most recent call last):
  File �[35m"<string>"�[0m, line �[35m12�[0m, in �[35m<module>�[0m
  File �[35m"<frozen importlib._bootstrap>"�[0m, line �[35m813�[0m, in �[35mmodule_from_spec�[0m
  File �[35m"<frozen importlib._bootstrap_external>"�[0m, line �[35m1316�[0m, in �[35mcreate_module�[0m
  File �[35m"<frozen importlib._bootstrap>"�[0m, line �[35m488�[0m, in �[35m_call_with_frames_removed�[0m
�[1;35mImportError�[0m: �[35mdlopen(/Users/buildbot/Library/Developer/XCTestDevices/22CEEEC0-69AF-41A1-B570-E2195120FCE2/data/Containers/Bundle/Application/781AEFA7-0473-4CB0-82EE-01996600BD3C/iOSTestbed.app/python/lib/python3.13/lib-dynload/_testcapi.cpython-313d-iphonesimulator.fwork, 0x0002): tried: '/Users/buildbot/buildarea/3.13.rkm-arm64-ios-simulator.iOS-simulator.arm64/build/build_oot/host/iOSTestbed.arm64-iphonesimulator.1719996652/DerivedData/Build/Products/Debug-iphonesimulator/_testcapi.cpython-313d-iphonesimulator.fwork' (no such file), '/Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/usr/lib/_testcapi.cpython-313d-iphonesimulator.fwork' (no such file), '/Library/Developer/CoreSimulator/Volumes/iOS_21F79/Library/Developer/CoreSimulator/Profiles/Runtimes/iOS 17.5.simruntime/Contents/Resources/RuntimeRoot/Users/buildbot/Library/Developer/XCTestDevices/22CEEEC0-69AF-41A1-B570-E2195120FCE2/data/Containers/Bundle/Application/781AEFA7-0473-4CB0-82EE-01996600BD3C/iOSTestbed.app/python/lib/python3.13/lib-dynload/_testcapi.cpython-313d-iphonesimulator.fwork' (no such file), '/Users/buildbot/Library/Developer/XCTestDevices/22CEEEC0-69AF-41A1-B570-E2195120FCE2/data/Containers/Bundle/Application/781AEFA7-0473-4CB0-82EE-01996600BD3C/iOSTestbed.app/python/lib/python3.13/lib-dynload/_testcapi.cpython-313d-iphonesimulator.fwork' (not a mach-o file)�[0m


Traceback (most recent call last):
  File "/Users/buildbot/Library/Developer/XCTestDevices/22CEEEC0-69AF-41A1-B570-E2195120FCE2/data/Containers/Bundle/Application/781AEFA7-0473-4CB0-82EE-01996600BD3C/iOSTestbed.app/python/lib/python3.13/test/datetimetester.py", line 6828, in test_type_check_in_subinterp
    self.assertEqual(ret, 0)
    ~~~~~~~~~~~~~~~~^^^^^^^^
AssertionError: -1 != 0

…ython#120829)

neonene added 2 commits June 21, 2024 20:04

add a test

d9bdc48

invalidate type caches on reload

7c10284

neonene requested review from abalkin and pganssle as code owners June 21, 2024 11:32

bedevere-app Bot mentioned this pull request Jun 21, 2024

test_datetime fails with a --forever argument #120782

Closed

bedevere-app Bot added the awaiting review label Jun 21, 2024

📜🤖 Added by blurb_it.

285c3b6

ericsnowcurrently approved these changes Jun 21, 2024

View reviewed changes

bedevere-app Bot added awaiting merge and removed awaiting review labels Jun 21, 2024

Eclips4 approved these changes Jun 21, 2024

View reviewed changes

kumaraditya303 approved these changes Jun 21, 2024

View reviewed changes

kumaraditya303 merged commit a81d434 into python:main Jun 21, 2024

bedevere-app Bot removed the awaiting merge label Jun 21, 2024

JelleZijlstra reviewed Jun 21, 2024

View reviewed changes

neonene deleted the reload branch June 21, 2024 20:13

mrahtz pushed a commit to mrahtz/cpython that referenced this pull request Jun 30, 2024

pythongh-120782 : Update internal type cache when reloading datetime (p…

a8fd23e

…ython#120829)

noahbkim pushed a commit to hudson-trading/cpython that referenced this pull request Jul 11, 2024

pythongh-120782 : Update internal type cache when reloading datetime (p…

f5e36f5

…ython#120829)

estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024

pythongh-120782 : Update internal type cache when reloading datetime (p…

7d4cb5d

…ython#120829)

+                              _datetime.time.max > _datetime.time.min
+                              _datetime.datetime.max > _datetime.datetime.min
+                              _datetime.timedelta.max > _datetime.timedelta.min
+                              isinstance(_datetime.timezone.min, _datetime.tzinfo)

gh-120782: Update internal type cache when reloading datetime by neonene · Pull Request #120829 · python/cpython · GitHub

Uh oh!

Uh oh!

gh-120782: Update internal type cache when reloading datetime - #120829

gh-120782: Update internal type cache when reloading datetime#120829
kumaraditya303 merged 3 commits into
python:mainfrom
neonene:reload

neonene commented Jun 21, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

Uh oh!

neonene commented Jun 21, 2024

Uh oh!

ericsnowcurrently left a comment

Uh oh!

Eclips4 left a comment

Uh oh!

JelleZijlstra Jun 21, 2024

Uh oh!

neonene Jun 21, 2024

Uh oh!

ericsnowcurrently Jun 21, 2024

Uh oh!

JelleZijlstra Jun 21, 2024

Uh oh!

JelleZijlstra Jun 21, 2024

Uh oh!

neonene commented Jun 21, 2024

Uh oh!

bedevere-app Bot commented Jun 21, 2024

Uh oh!

bedevere-bot commented Jul 3, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

gh-120782: Update internal type cache when reloading datetime by neonene · Pull Request #120829 · python/cpython · GitHub

Uh oh!

Uh oh!

gh-120782: Update internal type cache when reloading datetime - #120829

gh-120782: Update internal type cache when reloading datetime#120829kumaraditya303 merged 3 commits intopython:mainpython/cpython:mainfrom neonene:reloadCopy head branch name to clipboard

Conversation

neonene commented Jun 21, 2024 • edited by bedevere-app Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

neonene commented Jun 21, 2024

Uh oh!

ericsnowcurrently left a comment

Choose a reason for hiding this comment

Uh oh!

Eclips4 left a comment

Choose a reason for hiding this comment

Uh oh!

JelleZijlstra Jun 21, 2024

Choose a reason for hiding this comment

Uh oh!

neonene Jun 21, 2024

Choose a reason for hiding this comment

Uh oh!

ericsnowcurrently Jun 21, 2024

Choose a reason for hiding this comment

Uh oh!

JelleZijlstra Jun 21, 2024

Choose a reason for hiding this comment

Uh oh!

JelleZijlstra Jun 21, 2024

Choose a reason for hiding this comment

Uh oh!

neonene commented Jun 21, 2024

Uh oh!

bedevere-app Bot commented Jun 21, 2024

Uh oh!

bedevere-bot commented Jul 3, 2024

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

gh-120782: Update internal type cache when reloading datetime#120829
kumaraditya303 merged 3 commits into
python:mainfrom
neonene:reload

neonene commented Jun 21, 2024 •
edited by bedevere-app Bot
Loading