FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-107803: fix thread safety issue in double linked list implementation by kumaraditya303 · Pull Request #121007 · python/cpython · GitHub

/ cpython Public

gh-107803: fix thread safety issue in double linked list implementation - #121007

Merged
kumaraditya303 merged 5 commits into
python:mainfrom
kumaraditya303:asyncfix
Jun 26, 2024
ConversationCommits (5)ChecksFiles changed
Merged

gh-107803: fix thread safety issue in double linked list implementation #121007
kumaraditya303 merged 5 commits into
python:mainfrom
kumaraditya303:asyncfix

Conversation

kumaraditya303 commented Jun 25, 2024 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor

bedevere-app Bot mentioned this pull request Jun 25, 2024
Closed
kumaraditya303 requested a review from colesbury June 25, 2024 17:18
colesbury approved these changes Jun 25, 2024
View reviewed changes
Comment thread Modules/_asynciomodule.c Outdated
Comment thread Modules/_asynciomodule.c
kumaraditya303 enabled auto-merge (squash) June 25, 2024 18:01
colesbury reviewed Jun 25, 2024
View reviewed changes
Comment thread Modules/_asynciomodule.c Outdated
kumaraditya303 commented Jun 26, 2024
View reviewed changes
Comment thread Modules/_asynciomodule.c Outdated
kumaraditya303 merged commit 8223544 into python:main Jun 26, 2024
kumaraditya303 deleted the asyncfix branch June 26, 2024 05:20

bedevere-bot commented Jun 26, 2024

Copy link
Copy Markdown

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 Ubuntu NoGIL Refleaks 3.x has failed when building commit 8223544.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/1226/builds/2113) and take a look at the build logs.
  4. Check if the failure is related to this commit (8223544) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/1226/builds/2113

Failed tests:

  • test_functools

Test leaking resources:

  • test_functools: memory blocks

Summary of the results of the build (if available):

==

Click to see traceback logs 
remote: Enumerating objects: 13, done.        
remote: Counting objects:   7% (1/13)        
remote: Counting objects:  15% (2/13)        
remote: Counting objects:  23% (3/13)        
remote: Counting objects:  30% (4/13)        
remote: Counting objects:  38% (5/13)        
remote: Counting objects:  46% (6/13)        
remote: Counting objects:  53% (7/13)        
remote: Counting objects:  61% (8/13)        
remote: Counting objects:  69% (9/13)        
remote: Counting objects:  76% (10/13)        
remote: Counting objects:  84% (11/13)        
remote: Counting objects:  92% (12/13)        
remote: Counting objects: 100% (13/13)        
remote: Counting objects: 100% (13/13), done.        
remote: Compressing objects:  16% (1/6)        
remote: Compressing objects:  33% (2/6)        
remote: Compressing objects:  50% (3/6)        
remote: Compressing objects:  66% (4/6)        
remote: Compressing objects:  83% (5/6)        
remote: Compressing objects: 100% (6/6)        
remote: Compressing objects: 100% (6/6), done.        
remote: Total 7 (delta 6), reused 1 (delta 1), pack-reused 0        
From https://github.com/python/cpython
 * branch                  main       -> FETCH_HEAD
Note: switching to '82235449b85165add62c1b200299456a50a1d097'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by switching back to a branch.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -c with the switch command. Example:

  git switch -c <new-branch-name>

Or undo this operation with:

  git switch -

Turn off this advice by setting config variable advice.detachedHead to false

HEAD is now at 82235449b8 gh-107803: fix thread safety issue in double linked list implementation  (#121007)
Switched to and reset branch 'main'

configure: WARNING: no system libmpdecimal found; falling back to bundled libmpdecimal (deprecated and scheduled for removal in Python 3.15)

make: *** [Makefile:2252: buildbottest] Error 2

mrahtz pushed a commit to mrahtz/cpython that referenced this pull request Jun 30, 2024
pythongh-107803: fix thread safety issue in double linked list implem…
57e50d9 
…entation (python#121007)
noahbkim pushed a commit to hudson-trading/cpython that referenced this pull request Jul 11, 2024
pythongh-107803: fix thread safety issue in double linked list implem…
3f0607f 
…entation (python#121007)
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
pythongh-107803: fix thread safety issue in double linked list implem…
6970af9 
…entation (python#121007)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

colesbury colesbury approved these changes
1st1 Awaiting requested review from 1st1 1st1 is a code owner
asvetlov Awaiting requested review from asvetlov asvetlov is a code owner
gvanrossum Awaiting requested review from gvanrossum
willingc Awaiting requested review from willingc willingc is a code owner

Assignees

No one assigned

Labels

skip news topic-asyncio

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL