FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-119786: move frames documentation to InternalDocs and add details by iritkatriel · Pull Request #121009 · python/cpython · GitHub

/ cpython Public

gh-119786: move frames documentation to InternalDocs and add details - #121009

Merged
iritkatriel merged 4 commits into
python:mainfrom
iritkatriel:frames-doc
Jun 26, 2024
ConversationCommits (4)ChecksFiles changed
Merged

gh-119786: move frames documentation to InternalDocs and add details#121009
iritkatriel merged 4 commits into
python:mainfrom
iritkatriel:frames-doc

Conversation

iritkatriel commented Jun 25, 2024 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

iritkatriel added docs Documentation in the Doc dir interpreter-core (Objects, Python, Grammar, and Parser dirs) labels Jun 25, 2024
bedevere-app Bot mentioned this pull request Jun 25, 2024
Closed
iritkatriel requested a review from markshannon June 25, 2024 18:01
markshannon reviewed Jun 26, 2024
View reviewed changes

markshannon left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I've a few suggestions.

Also, FYI:

Comment thread InternalDocs/frames.md Outdated

* Local variables (including arguments, cells and free variables)
* Evaluation stack
* Evaluation stack and instruction pointer

markshannon Jun 26, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I don't think the instruction pointer belongs here (at least not conceptually).
I would add it to specials/linkage

iritkatriel Jun 26, 2024

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

How about I change this line to
Execution state: evaluation stack, instruction pointer ?

It feels like instruction pointer is internal to the frame's working, rather than linking to external frames or objects.

Comment thread InternalDocs/frames.md Outdated
Comment thread InternalDocs/frames.md Outdated
Comment thread InternalDocs/frames.md Outdated

markshannon commented Jun 26, 2024

Copy link
Copy Markdown
Member

I think it would make sense to merge the "specials" and "linkage" sections. The only real "linkage" is the previous pointer.

So, maybe replace "specials and linkage" with "specials", and when specifically referring to "linkage", say previous poointer?

markshannon approved these changes Jun 26, 2024
View reviewed changes

markshannon left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks

iritkatriel merged commit c878767 into python:main Jun 26, 2024
mrahtz pushed a commit to mrahtz/cpython that referenced this pull request Jun 30, 2024
pythongh-119786: move frames documentation to InternalDocs and add de…
647f5a8 
…tails (python#121009)
noahbkim pushed a commit to hudson-trading/cpython that referenced this pull request Jul 11, 2024
pythongh-119786: move frames documentation to InternalDocs and add de…
191579a 
…tails (python#121009)
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
pythongh-119786: move frames documentation to InternalDocs and add de…
33dedab 
…tails (python#121009)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

markshannon markshannon approved these changes

Assignees

No one assigned

Labels

docs Documentation in the Doc dir interpreter-core (Objects, Python, Grammar, and Parser dirs) skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL