FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[3.7] Add versionadded directives to ssl.minimum_version and ssl.maxi… by csabella · Pull Request #12101 · python/cpython · GitHub

/ cpython Public

[3.7] Add versionadded directives to ssl.minimum_version and ssl.maxi… - #12101

Merged
miss-islington merged 1 commit into
python:3.7from
csabella:backport-ae2ea33-3.7
Feb 28, 2019
ConversationCommits (1)ChecksFiles changed
Merged

[3.7] Add versionadded directives to ssl.minimum_version and ssl.maxi…#12101
miss-islington merged 1 commit into
python:3.7from
csabella:backport-ae2ea33-3.7

Conversation

csabella commented Feb 28, 2019

Copy link
Copy Markdown
Contributor

…mum_version (GH-11894).

(cherry picked from commit ae2ea33)

Co-authored-by: Zhiming Wang i@zhimingwang.org

[3.7] Add versionadded directives to ssl.minimum_version and ssl.maxi…
08725bf 
…mum_version (pythonGH-11894).

(cherry picked from commit ae2ea33)

Co-authored-by: Zhiming Wang <i@zhimingwang.org>
bedevere-bot mentioned this pull request Feb 28, 2019
Merged
bedevere-bot added skip issue skip news docs Documentation in the Doc dir labels Feb 28, 2019

miss-islington commented Feb 28, 2019

Copy link
Copy Markdown
Contributor

@csabella: Status check is done, and it's a success ✅ .

miss-islington merged commit 7dc322f into python:3.7 Feb 28, 2019
csabella deleted the backport-ae2ea33-3.7 branch February 28, 2019 18:12
vstinner reviewed Feb 28, 2019
View reviewed changes
Comment thread Doc/library/ssl.rst
Only available with OpenSSL 1.1.1 and TLS 1.3 enabled. Without TLS 1.3
support, the method raises :exc:`NotImplementedError`.

.. versionadded:: 3.7.1

vstinner Feb 28, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

hum wait, why is it version 3.8 in the master branch but 3.7.1 in the 3.7 branch? The versionadded should be the same in 3.7 and master branches, no? cc @csabella @tiran (I only checked verify_client_post_handshake, I didn't check other versionadded markups.)

csabella Feb 28, 2019

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

That's how it was when originally added in GH-9460 and GH-9505, so I didn't change it. If it should be 3.7.1 on both, I'll update master.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

vstinner vstinner left review comments

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL