Repository navigation
gh-120950: Fix overflow in math.log() with large int-like argument - #121011
Merged
serhiy-storchaka merged 7 commits intoNov 11, 2025
Merged
serhiy-storchaka merged 7 commits into
serhiy-storchaka merged 7 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Handling of arbitrary large int-like argument is now consistent with handling arbitrary large int arguments.
Copy link
Copy Markdown
Member
Author
|
This is not optimal, because for large int-like argument __index__ is called twice and OverflowError is raised and silenced twice. |
Sorry, something went wrong.
skirpichev
reviewed
Jun 28, 2024
skirpichev
reviewed
Jul 25, 2024
Comment thread
Modules/mathmodule.c
mdickinson
approved these changes
Aug 2, 2024
mdickinson
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
This LGTM.
Sorry, something went wrong.
skirpichev
reviewed
Nov 2, 2024
skirpichev
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Now this pr has conflicts (which seems to be easy to fix, however).
Lets merge this; it has approval from Mark. LGTM with one cleanup, as _PyLong_Frexp() now not raises.
Sorry, something went wrong.
Comment thread
Modules/mathmodule.c
Outdated
StanFromIreland
pushed a commit
to StanFromIreland/cpython
that referenced
this pull request
Dec 6, 2025
…ent (pythonGH-121011) Handling of arbitrary large int-like argument is now consistent with handling arbitrary large int arguments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Handling of arbitrary large int-like argument is now consistent with handling arbitrary large int arguments.