gh-121040: Use __attribute__((fallthrough)) - #121044
Merged
vstinner merged 6 commits intoJun 27, 2024
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Annotate explicitly "fall through" switch cases with a new _Py_FALLTHROUGH macro which uses __attribute__((fallthrough)) if available. Fix warnings when using -Wimplicit-fallthrough compiler flag.
vstinner
requested review from
brettcannon,
corona10,
ericsnowcurrently,
gpshead,
iritkatriel,
markshannon,
ncoghlan,
tiran and
warsaw
as code owners
June 26, 2024 12:52
sobolevn
reviewed
Jun 26, 2024
sobolevn
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Looks like you need to run make regen-cases (or maybe even make regen-all) :)
Sorry, something went wrong.
Comment thread
Include/pyport.h
Outdated
Copy link
Copy Markdown
Member
Author
Done. |
Sorry, something went wrong.
AlexWaygood
reviewed
Jun 26, 2024
Comment thread
Include/pyport.h
Outdated
No longer define __has_attribute() if it's not defined. Move also _Py__has_builtin() at the top of pyport.h.
ericsnowcurrently
approved these changes
Jun 26, 2024
ericsnowcurrently
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM
I left one small comment where you might consider a slightly different spelling, but I'll leave that up to you.
Sorry, something went wrong.
Comment thread
Python/pyhash.c
brettcannon
removed their request for review
June 26, 2024 17:35
vstinner
enabled auto-merge (squash)
June 27, 2024 09:38
Copy link
Copy Markdown
Member
Author
|
I tested my change with -Wimplicit-fallthrough=5 which ignores all comments. There are only remaining comments on Modules/expat/ when --with-system-expat is not used, not in the Python code base anymore. See also the article about the flag: https://developers.redhat.com/blog/2017/03/10/wimplicit-fallthrough-in-gcc-7 |
Sorry, something went wrong.
mrahtz
pushed a commit
to mrahtz/cpython
that referenced
this pull request
Jun 30, 2024
Fix warnings when using -Wimplicit-fallthrough compiler flag. Annotate explicitly "fall through" switch cases with a new _Py_FALLTHROUGH macro which uses __attribute__((fallthrough)) if available. Replace "fall through" comments with _Py_FALLTHROUGH. Add _Py__has_attribute() macro. No longer define __has_attribute() macro if it's not defined. Move also _Py__has_builtin() at the top of pyport.h. Co-Authored-By: Nikita Sobolev <mail@sobolevn.me>
noahbkim
pushed a commit
to hudson-trading/cpython
that referenced
this pull request
Jul 11, 2024
Fix warnings when using -Wimplicit-fallthrough compiler flag. Annotate explicitly "fall through" switch cases with a new _Py_FALLTHROUGH macro which uses __attribute__((fallthrough)) if available. Replace "fall through" comments with _Py_FALLTHROUGH. Add _Py__has_attribute() macro. No longer define __has_attribute() macro if it's not defined. Move also _Py__has_builtin() at the top of pyport.h. Co-Authored-By: Nikita Sobolev <mail@sobolevn.me>
estyxx
pushed a commit
to estyxx/cpython
that referenced
this pull request
Jul 17, 2024
Fix warnings when using -Wimplicit-fallthrough compiler flag. Annotate explicitly "fall through" switch cases with a new _Py_FALLTHROUGH macro which uses __attribute__((fallthrough)) if available. Replace "fall through" comments with _Py_FALLTHROUGH. Add _Py__has_attribute() macro. No longer define __has_attribute() macro if it's not defined. Move also _Py__has_builtin() at the top of pyport.h. Co-Authored-By: Nikita Sobolev <mail@sobolevn.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Annotate explicitly "fall through" switch cases with a new _Py_FALLTHROUGH macro which uses attribute((fallthrough)) if available.
Fix warnings when using -Wimplicit-fallthrough compiler flag.