gh-121008: Fix idlelib.run tests - #121046
Conversation
Sorry, something went wrong.
When testing IDLE, don't create a Tk to avoid side effects such as installing a PyOS_InputHook hook.
|
Without this change, ./python -m test -u all,-gui test_idle test_pyrepl hangs on Linux: it is blocked until I press ENTER. With this change, the same command no longer hangs. |
Sorry, something went wrong.
ambv
left a comment
There was a problem hiding this comment.
Fixes the issue for me on Ubuntu and macOS, both GUI builds. Tests pass with:
> /Volumes/RAMDisk/installed-main/bin/python3 -E -Wd -m test --slowest --fail-env-changed -uall test_idle test_pyrepl Using random seed: 2738848300 Raised RLIMIT_NOFILE: 256 -> 1024 0:00:00 load avg: 9.16 Run 2 tests sequentially in a single process 0:00:00 load avg: 9.16 [1/2] test_idle 0:00:09 load avg: 9.14 [2/2] test_pyrepl == Tests result: SUCCESS == 10 slowest tests: - test_idle: 9.3 sec - test_pyrepl: 4.5 sec All 2 tests OK. Total duration: 13.9 sec Total tests: run=740 skipped=5 Total test files: run=2/2 Result: SUCCESS
Sorry, something went wrong.
|
Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13. |
Sorry, something went wrong.
When testing IDLE, don't create a Tk to avoid side effects such as installing a PyOS_InputHook hook. (cherry picked from commit 44eafd6) Co-authored-by: Victor Stinner <vstinner@python.org>
|
GH-121049 is a backport of this pull request to the 3.13 branch. |
Sorry, something went wrong.
|
Ok, let me merge this change and see how it goes. Thanks for the review @ambv. |
Sorry, something went wrong.
When testing IDLE, don't create a Tk to avoid side effects such as installing a PyOS_InputHook hook.
When testing IDLE, don't create a Tk to avoid side effects such as installing a PyOS_InputHook hook.
When testing IDLE, don't create a Tk to avoid side effects such as installing a PyOS_InputHook hook.
When testing IDLE, don't create a Tk to avoid side effects such as installing a PyOS_InputHook hook.