FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-120593: Fix const qualifier in _PyLong_CompactValue() by vstinner · Pull Request #121053 · python/cpython · GitHub

/ cpython Public

gh-120593: Fix const qualifier in _PyLong_CompactValue() - #121053

Merged
vstinner merged 1 commit into
python:mainfrom
vstinner:long_compact
Jun 26, 2024
ConversationCommits (1)ChecksFiles changed
Merged

gh-120593: Fix const qualifier in _PyLong_CompactValue()#121053
vstinner merged 1 commit into
python:mainfrom
vstinner:long_compact

Conversation

vstinner commented Jun 26, 2024 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

Remove the const qualifier of the argument of functions:

  • _PyLong_IsCompact()
  • _PyLong_CompactValue()

Py_TYPE() argument is not const.

Fix the compiler warning:

  Include/cpython/longintrepr.h: In function ‘_PyLong_CompactValue’: Include/pyport.h:19:31: error: cast discards ‘const’ qualifier from pointer target type [-Werror=cast-qual]
  (...) 
  Include/cpython/longintrepr.h:133:30: note: in expansion of macro ‘Py_TYPE’ assert(PyType_HasFeature(Py_TYPE(op), Py_TPFLAGS_LONG_SUBCLASS));

pythongh-120593: Fix const qualifier in _PyLong_CompactValue()
a742884 
Remove the const qualifier of the argument of functions:

* _PyLong_IsCompact()
* _PyLong_CompactValue()

Py_TYPE() argument is not const.

Fix the compiler warning:

  Include/cpython/longintrepr.h: In function ‘_PyLong_CompactValue’:
  Include/pyport.h:19:31: error: cast discards ‘const’ qualifier from
  pointer target type [-Werror=cast-qual]
    (...)
  Include/cpython/longintrepr.h:133:30: note: in expansion of macro
  ‘Py_TYPE’
    assert(PyType_HasFeature(Py_TYPE(op), Py_TPFLAGS_LONG_SUBCLASS));
bedevere-app Bot mentioned this pull request Jun 26, 2024
Closed

vstinner commented Jun 26, 2024

Copy link
Copy Markdown
Member Author

The important part is to respect the -Werror=cast-qual flag (avoid compiler warnings) in the public Python C API.

In Python implementation and the internal C API, we don't have to worry about this flag, since we don't use it.

vstinner added the needs backport to 3.13 bugs and security fixes label Jun 26, 2024
vstinner merged commit e51e880 into python:main Jun 26, 2024
vstinner deleted the long_compact branch June 26, 2024 18:11

miss-islington-app Bot commented Jun 26, 2024

Copy link
Copy Markdown

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington-app Bot commented Jun 26, 2024

Copy link
Copy Markdown

Sorry, @vstinner, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker e51e880e75d79687b54a71351266e29ee349b4b8 3.13

vstinner removed the needs backport to 3.13 bugs and security fixes label Jun 26, 2024

vstinner commented Jun 26, 2024 •
edited
Loading

Copy link
Copy Markdown
Member Author

The backport to Python 3.13 is not needed.

mrahtz pushed a commit to mrahtz/cpython that referenced this pull request Jun 30, 2024
pythongh-120593: Fix const qualifier in _PyLong_CompactValue() (pytho…
f003fd6 
…n#121053)

Remove the const qualifier of the argument of functions:

* _PyLong_IsCompact()
* _PyLong_CompactValue()

Py_TYPE() argument is not const.

Fix the compiler warning:

  Include/cpython/longintrepr.h: In function ‘_PyLong_CompactValue’:
  Include/pyport.h:19:31: error: cast discards ‘const’ qualifier from
  pointer target type [-Werror=cast-qual]
    (...)
  Include/cpython/longintrepr.h:133:30: note: in expansion of macro
  ‘Py_TYPE’
    assert(PyType_HasFeature(Py_TYPE(op), Py_TPFLAGS_LONG_SUBCLASS));
noahbkim pushed a commit to hudson-trading/cpython that referenced this pull request Jul 11, 2024
pythongh-120593: Fix const qualifier in _PyLong_CompactValue() (pytho…
c5f93f4 
…n#121053)

Remove the const qualifier of the argument of functions:

* _PyLong_IsCompact()
* _PyLong_CompactValue()

Py_TYPE() argument is not const.

Fix the compiler warning:

  Include/cpython/longintrepr.h: In function ‘_PyLong_CompactValue’:
  Include/pyport.h:19:31: error: cast discards ‘const’ qualifier from
  pointer target type [-Werror=cast-qual]
    (...)
  Include/cpython/longintrepr.h:133:30: note: in expansion of macro
  ‘Py_TYPE’
    assert(PyType_HasFeature(Py_TYPE(op), Py_TPFLAGS_LONG_SUBCLASS));

markshannon commented Jul 15, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

The const modifier is correct.
Please don't remove them, they add some much needed type safety to our C code.
If Py_TYPE() argument is not const, then fix that, don't weaken the types of other code.

estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
pythongh-120593: Fix const qualifier in _PyLong_CompactValue() (pytho…
bbf3d03 
…n#121053)

Remove the const qualifier of the argument of functions:

* _PyLong_IsCompact()
* _PyLong_CompactValue()

Py_TYPE() argument is not const.

Fix the compiler warning:

  Include/cpython/longintrepr.h: In function ‘_PyLong_CompactValue’:
  Include/pyport.h:19:31: error: cast discards ‘const’ qualifier from
  pointer target type [-Werror=cast-qual]
    (...)
  Include/cpython/longintrepr.h:133:30: note: in expansion of macro
  ‘Py_TYPE’
    assert(PyType_HasFeature(Py_TYPE(op), Py_TPFLAGS_LONG_SUBCLASS));

vstinner commented Jul 27, 2024

Copy link
Copy Markdown
Member Author

The const modifier is correct. Please don't remove them, they add some much needed type safety to our C code.

Ok, I restored the const modified with PR gh-122367.

If Py_TYPE() argument is not const, then fix that, don't weaken the types of other code.

I tried hard to use const PyObject*, but it went badly: #91768 I'm not convinced that it helps the compiler to optimize.

In my PR, I just restored the code to avoid Py_TYPE().

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

vstinner

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL