Repository navigation
gh-61103: Support float and long double complex types in ctypes module - #121248
Merged
vstinner merged 7 commits intoJul 3, 2024
Merged
vstinner merged 7 commits into
vstinner merged 7 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
… module This amends 6988ff0: memory allocation for stginfo->ffi_type_pointer.elements in PyCSimpleType_init() should be more generic (perhaps someday fmt->pffi_type->elements will be not a two-elements array). It should finally resolve python#61103.
Copy link
Copy Markdown
Contributor
|
Looking good, if merged this would fix the table of complex types only having a single row. |
Sorry, something went wrong.
vstinner
reviewed
Jul 2, 2024
Comment thread
Lib/test/test_ctypes/test_libc.py
Comment thread
Lib/test/test_ctypes/test_libc.py
Comment thread
Lib/test/test_ctypes/test_numbers.py
Comment thread
Lib/test/test_ctypes/test_numbers.py
Outdated
Comment thread
Modules/_complex.h
Comment thread
Modules/_complex.h
Comment thread
Modules/_ctypes/_ctypes_test.c
Comment thread
Modules/_ctypes/_ctypes_test.c
Co-authored-by: Victor Stinner <vstinner@python.org>
vstinner
reviewed
Jul 2, 2024
Comment thread
Lib/test/test_ctypes/test_numbers.py
Outdated
vstinner
reviewed
Jul 2, 2024
Comment thread
Misc/NEWS.d/next/Library/2024-07-02-05-08-16.gh-issue-61103.TMxkuM.rst
Outdated
skirpichev
commented
Jul 2, 2024
Comment thread
Misc/NEWS.d/next/Library/2024-06-23-07-23-08.gh-issue-61103.ca_U_l.rst
Outdated
picnixz
reviewed
Jul 2, 2024
Comment thread
Doc/library/ctypes.rst
Comment thread
Misc/NEWS.d/next/Library/2024-06-23-07-23-08.gh-issue-61103.ca_U_l.rst
Outdated
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
vstinner
approved these changes
Jul 3, 2024
vstinner
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
noahbkim
pushed a commit
to hudson-trading/cpython
that referenced
this pull request
Jul 11, 2024
… module (python#121248) This amends 6988ff0: memory allocation for stginfo->ffi_type_pointer.elements in PyCSimpleType_init() should be more generic (perhaps someday fmt->pffi_type->elements will be not a two-elements array). It should finally resolve python#61103. Co-authored-by: Victor Stinner <vstinner@python.org> Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
estyxx
pushed a commit
to estyxx/cpython
that referenced
this pull request
Jul 17, 2024
… module (python#121248) This amends 6988ff0: memory allocation for stginfo->ffi_type_pointer.elements in PyCSimpleType_init() should be more generic (perhaps someday fmt->pffi_type->elements will be not a two-elements array). It should finally resolve python#61103. Co-authored-by: Victor Stinner <vstinner@python.org> Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This amends 6988ff0: memory allocation for stginfo->ffi_type_pointer.elements in PyCSimpleType_init() should be more generic (perhaps someday fmt->pffi_type->elements will be not a two-elements array).
It should finally resolve #61103.
📚 Documentation preview 📚: https://cpython-previews--121248.org.readthedocs.build/