FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-119909: Fix ``NameError`` in ``asyncio`` REPL by Eclips4 · Pull Request #121341 · python/cpython · GitHub

/ cpython Public

gh-119909: Fix NameError in asyncio REPL - #121341

Merged
ambv merged 1 commit into
python:mainfrom
Eclips4:issue-119909
Jul 6, 2024
ConversationCommits (1)ChecksFiles changed
Merged

gh-119909: Fix NameError in asyncio REPL#121341
ambv merged 1 commit into
python:mainfrom
Eclips4:issue-119909

Conversation

Eclips4 commented Jul 3, 2024 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

Seems that was a culprit, with that I cannot reproduce failure in test_asyncio_repl_is_ok:

./python -m test -R 100:100 test_repl test_list -j 2
Using random seed: 985022535
0:00:00 load avg: 0.21 Run 2 tests in parallel using 2 worker processes
0:00:30 load avg: 0.92 running (2): test_repl (30.0 sec), test_list (30.0 sec)
0:01:00 load avg: 1.34 running (2): test_repl (1 min), test_list (1 min)
0:01:30 load avg: 1.60 running (2): test_repl (1 min 30 sec), test_list (1 min 30 sec)
0:01:55 load avg: 1.74 [1/2] test_list passed (1 min 55 sec) -- running (1): test_repl (1 min 55 sec)
beginning 200 repetitions. Showing number of leaks (. for 0 or less, X for 10 or more)
1234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890:1234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890
XX.................................................................................................. ....................................................................................................
0:02:25 load avg: 1.45 running (1): test_repl (2 min 25 sec)
0:02:55 load avg: 1.27 running (1): test_repl (2 min 55 sec)
0:03:23 load avg: 1.16 [2/2] test_repl passed (3 min 23 sec)
beginning 200 repetitions. Showing number of leaks (. for 0 or less, X for 10 or more)
1234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890:1234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890
XX.................................................................................................. ....................................................................................................

== Tests result: SUCCESS ==

All 2 tests OK.

Total duration: 3 min 23 sec
Total tests: run=70
Total test files: run=2/2
Result: SUCCESS

Eclips4 requested a review from ambv July 3, 2024 17:33
bedevere-app Bot mentioned this pull request Jul 3, 2024
Closed
Eclips4 commented Jul 3, 2024
View reviewed changes
Comment thread Lib/asyncio/__main__.py
raise RuntimeError(err)
except Exception as e:
console.interact(banner="", exitmsg=exit_message)
console.interact(banner="", exitmsg="")

Eclips4 Jul 3, 2024

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Tough, not sure which exitmsg would be appropriate there.

Eclips4 mentioned this pull request Jul 6, 2024
Closed
Eclips4 added the needs backport to 3.13 bugs and security fixes label Jul 6, 2024
ambv merged commit 1143894 into python:main Jul 6, 2024

miss-islington-app Bot commented Jul 6, 2024

Copy link
Copy Markdown

Thanks @Eclips4 for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 6, 2024
pythongh-119909: Fix NameError in asyncio REPL (pythonGH-121341)
ab9ccbe 
(cherry picked from commit 1143894)

Co-authored-by: Kirill Podoprigora <kirill.bast9@mail.ru>

bedevere-app Bot commented Jul 6, 2024

Copy link
Copy Markdown

GH-121447 is a backport of this pull request to the 3.13 branch.

bedevere-app Bot removed the needs backport to 3.13 bugs and security fixes label Jul 6, 2024
vstinner pushed a commit that referenced this pull request Jul 6, 2024
[3.13] gh-119909: Fix NameError in asyncio REPL (GH-121341) (#…
c2ad5fd 
…121447)

gh-119909: Fix ``NameError`` in ``asyncio`` REPL (GH-121341)
(cherry picked from commit 1143894)

Co-authored-by: Kirill Podoprigora <kirill.bast9@mail.ru>
noahbkim pushed a commit to hudson-trading/cpython that referenced this pull request Jul 11, 2024
pythongh-119909: Fix NameError in asyncio REPL (python#121341)
78193f3
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
pythongh-119909: Fix NameError in asyncio REPL (python#121341)
0108bfd
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

ambv Awaiting requested review from ambv

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL