Repository navigation
gh-59110: Extract function for _add_implicit_dirs. - #121378
Closed
jaraco wants to merge 2 commits into
Closed
jaraco wants to merge 2 commits into
jaraco wants to merge 2 commits into
Conversation
jaraco
requested review from
brettcannon,
ericsnowcurrently,
ncoghlan and
warsaw
as code owners
July 4, 2024 19:37
Copy link
Copy Markdown
Member
|
I do not see benefits, Actually, this looks like pessimization. The current code stops adding implicit parent dirs if it found already added dir. Your code continues to generate them. For example, if there are foo/bar/baz/a.py, foo/bar/baz/b.py and foo/bar/baz/c.py, it will calculate foo/bar/ and foo/ three times. You need to use dict.fromkeys() to de-duplicate them. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.