gh-121266: Remove Py_ALWAYS_INLINE in dictobject.c - #121493
Merged
vstinner merged 1 commit intoJul 18, 2024
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
methane
reviewed
Jul 8, 2024
Comment thread
Objects/dictobject.c
Outdated
compare_unicode_generic(), compare_unicode_unicode() and compare_generic() are callbacks used by do_lookup(). When enabling assertions, it's not possible to inline these functions.
vstinner
force-pushed
the
remove_always_inline
branch
from
cd9b693 to
cc02eac
Compare
July 17, 2024 19:54
Copy link
Copy Markdown
Member
Author
|
@methane: Would you mind to review the rebased PR? |
Sorry, something went wrong.
methane
approved these changes
Jul 18, 2024
Copy link
Copy Markdown
|
Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13. |
Sorry, something went wrong.
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jul 21, 2024
Copy link
Copy Markdown
|
GH-122095 is a backport of this pull request to the 3.13 branch. |
Sorry, something went wrong.
vstinner
added a commit
that referenced
this pull request
Jul 21, 2024
…#122095) gh-121266: Remove Py_ALWAYS_INLINE in dictobject.c (GH-121493) compare_unicode_generic(), compare_unicode_unicode() and compare_generic() are callbacks used by do_lookup(). When enabling assertions, it's not possible to inline these functions. (cherry picked from commit c5a6b9a) Co-authored-by: Victor Stinner <vstinner@python.org>
Copy link
Copy Markdown
⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️Hi! The buildbot s390x Fedora 3.13 has failed when building commit e458268. What do you need to do:
You can take a look at the buildbot page here: https://buildbot.python.org/#builders/1403/builds/223 Failed tests:
Failed subtests:
Summary of the results of the build (if available): == Click to see traceback logsTraceback (most recent call last):
File "/home/dje/cpython-buildarea/3.13.edelsohn-fedora-z/build/Lib/test/test_pyrepl/test_pyrepl.py", line 995, in _run_repl_globals_test
self.fail(f"{var}= not found in output")
~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: FOO= not found in output
Traceback (most recent call last):
File "/home/dje/cpython-buildarea/3.13.edelsohn-fedora-z/build/Lib/test/test_pyrepl/test_pyrepl.py", line 995, in _run_repl_globals_test
self.fail(f"{var}= not found in output")
~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: __name__= not found in output
|
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
compare_unicode_generic(), compare_unicode_unicode() and compare_generic() are callbacks used by do_lookup(). When enabling assertions, it's not possible to inline these functions.